From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66186: "make lisp/eshell/esh-proc-tests" fails intermittently since 7e50861ca7ed3f620fe62ac6572f6e88b3600ece Date: Mon, 25 Sep 2023 07:52:22 +0300 Message-ID: <83fs323ldl.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8172"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66186@debbugs.gnu.org, jschmidt4gnu@vodafonemail.de To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 25 06:54:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qkdbl-0001vW-J7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 25 Sep 2023 06:54:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkdbU-00008M-6p; Mon, 25 Sep 2023 00:53:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkdbS-000086-D8 for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 00:53:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkdbS-0003Ys-52 for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 00:53:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkdbe-0000ts-9N for bug-gnu-emacs@gnu.org; Mon, 25 Sep 2023 00:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Sep 2023 04:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66186 X-GNU-PR-Package: emacs Original-Received: via spool by 66186-submit@debbugs.gnu.org id=B66186.16956176003411 (code B ref 66186); Mon, 25 Sep 2023 04:54:02 +0000 Original-Received: (at 66186) by debbugs.gnu.org; 25 Sep 2023 04:53:20 +0000 Original-Received: from localhost ([127.0.0.1]:43891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkday-0000sw-8d for submit@debbugs.gnu.org; Mon, 25 Sep 2023 00:53:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkdav-0000sj-Nt for 66186@debbugs.gnu.org; Mon, 25 Sep 2023 00:53:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkdaW-0003Tb-OT; Mon, 25 Sep 2023 00:52:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RzX/XVVnrUN+rIarSDzGNuy8Iw5eweFpnjAmmXD1CzM=; b=T8mevGVbr7JF VP7Cf9ie0+romD3qQ1NrSZWVbsDYe7F99VIbeGUfBAmgd+NfJzw2WcxRZjCPTO595kKB/7b0Evpx8 XM2WE0wXi8kvHXQU58a3c19vdHuVGfvMKgQ5ePtp3wOLy6+xNv+lOj/zkYaRtV8vhqRVb1AlauB7s YXSM9vgqYaKMaThvaUHj5+i3pGpOHt+nvpISQrTw5O8HOIPnpmm2t8vJkrAov8o7dHEEmGVVZNx9F 5RDYv2kIKzZG8UJ0uYnqoaQLPpZpBbWzVZVCRaOJ0knyv9bHUW8K0of4qG03ZeuwtcVhkj0dfOkAk eVAxFxY+xbD8/OOuFHaUJQ==; In-Reply-To: (message from Jim Porter on Sun, 24 Sep 2023 16:02:03 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271292 Archived-At: > Date: Sun, 24 Sep 2023 16:02:03 -0700 > From: Jim Porter > > > Thread 1 "emacs" received signal SIGPIPE, Broken pipe. > > 0x00007ffff57bffef in write () from /lib/x86_64-linux-gnu/libpthread.so.0 > > #0 0x00007ffff57bffef in write () at /lib/x86_64-linux-gnu/libpthread.so.0 > > #1 0x00005555556f2f08 in emacs_full_write (fd=19, buf=0x5555565918b8 "hi", nbyte=2, interruptible=-1) at sysdep.c:2812 > [snip] > > Thanks. This looks like it's caused when Eshell runs a command something > like this: > > echo hi | sh -c 'if [ -t 0 ]; then echo stdin; fi; ...' > > (Note that the pipe above is handled entirely by Eshell, using > 'process-send-string' in this case.) I'm guessing that sometimes, the > 'sh' process has exited by the time Eshell calls '(process-send-string > PROC "hi")'. Presumably, the commit you identified (which just changed > some debug logging) altered the timings by just enough to trigger this > race condition for you. > > However, I don't understand why this would cause an abort though; > normally, 'process-send-string' should just signal an Elisp error (which > Eshell then catches and does the right thing with it). Maybe there's a > bug somewhere in process.c where it's not correctly handling the (real) > SIGPIPE signal and converting it to an Elisp signal? In batch mode, SIGPIPE is not ignored by Emacs, see init_signals. This was changed 11 years ago, see commit 4d7e6e51dd. Perhaps Eshell should check that the process is still alive before calling process-send-string?