From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66187: read-file-name unexpected behavior when MUSTMATCH is a function Date: Fri, 06 Oct 2023 07:45:39 +0300 Message-ID: <83fs2o2wb0.fsf@gnu.org> References: <87r0mni6m1.fsf@breatheoutbreathe.in> <87bkdq3nw6.fsf@web.de> <875y3yx221.fsf@breatheoutbreathe.in> <87pm260wh9.fsf@web.de> <87v8bx48ww.fsf@breatheoutbreathe.in> <87msx8sbpv.fsf@web.de> <87bkdoh1gy.fsf@breatheoutbreathe.in> <87h6ngs85e.fsf@web.de> <87ttr7nzyj.fsf@breatheoutbreathe.in> <83pm1u6f8l.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27051"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, philipk@posteo.net, 66187@debbugs.gnu.org, joseph@breatheoutbreathe.in To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 06 06:46:57 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qocjp-0006qk-TB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 06 Oct 2023 06:46:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qocje-0000Fl-C3; Fri, 06 Oct 2023 00:46:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qocjc-0000Fc-JE for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 00:46:44 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qocjc-0005qx-9r for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 00:46:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qocju-0000ZN-GA for bug-gnu-emacs@gnu.org; Fri, 06 Oct 2023 00:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Oct 2023 04:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66187 X-GNU-PR-Package: emacs Original-Received: via spool by 66187-submit@debbugs.gnu.org id=B66187.16965675652108 (code B ref 66187); Fri, 06 Oct 2023 04:47:02 +0000 Original-Received: (at 66187) by debbugs.gnu.org; 6 Oct 2023 04:46:05 +0000 Original-Received: from localhost ([127.0.0.1]:48988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qociw-0000Xh-3H for submit@debbugs.gnu.org; Fri, 06 Oct 2023 00:46:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qociq-0000XK-U3 for 66187@debbugs.gnu.org; Fri, 06 Oct 2023 00:46:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qociR-0005R4-2G; Fri, 06 Oct 2023 00:45:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0icmEpKydXKcYdxeAV8IL+nb6GvNCd0oXjHMj6XfW5I=; b=Bc5h9S9UojpH v6hQT7OFi1xSHYjlFKsH3zKaoMxEGoluY7LiSHDOAhmWS927sdTwe1T3qBwwtRgr6Uh+KHleX9CIc wPJKi/UJtuzhSvm5I3qBVglkpZ34bSGeUdNaYw9cSdm7/94EqGTijhWZmplmXrNPtRB2e51aL0hn2 ObffiZ0noNvRWljPhbPnT2EdanPu/O/Z58JxHxV/cdAXSnhhXOlWI9jE8xBnR7V+eo8R2pJNTKce+ 5W7LiE8MCokKw+WFbcQUtm//xmuBtdN8WWxujt23r+ax8/vNgjEzP1WY6UkjB/u5iE0cQs44kM3U7 iNNiy/3JDNKtOFZCkxjSRw==; In-Reply-To: (message from Stefan Monnier on Thu, 05 Oct 2023 15:34:32 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271924 Archived-At: > From: Stefan Monnier > Cc: Joseph Turner , michael_heerdegen@web.de, > philipk@posteo.net, 66187@debbugs.gnu.org > Date: Thu, 05 Oct 2023 15:34:32 -0400 > > >> For example, given: > >> > >> (completing-read "Prompt: " '("a" "b") nil > >> (lambda (input) > >> (string= "a" input))) > >> > >> I expected that the prompt would refuse to complete "b". I was wrong. > >> > >> Since completing-read is such a fundamental part of Emacs, I doubt it > >> will be possible to change this behavior. What do you think about the > >> attached patch to clarify the completing-read docstring? > > The use of a function as `require-match` is brand new in Emacs-29, so > I think it's not too late to fix it. I think rather than fixing the doc > we should fix the behavior, e.g. with the patch below. What change in behavior (wrt Emacs 29.1) does this patch cause?