From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66655: 29.1; Clicking buttons sometimes doesn't work Date: Wed, 25 Oct 2023 21:29:55 +0300 Message-ID: <83fs1yimho.fsf@gnu.org> References: <1d9187b71e7288eaf08ac9a2f0559bdf@gmail.com> <8334y4s0oe.fsf@gnu.org> <83v8axmbsh.fsf@gnu.org> <83y1fskyjj.fsf@gnu.org> <83il6wktxt.fsf@gnu.org> <83h6mgkst3.fsf@gnu.org> <83edhkkrzd.fsf@gnu.org> <83bkcokoxu.fsf@gnu.org> <83pm12kj44.fsf@gnu.org> <83msw6it17.fsf@gnu.org> <83h6meiraw.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2603"; mail-complaints-to="usenet@ciao.gmane.io" Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 25 20:30:59 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qvieh-0000UU-Gw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Oct 2023 20:30:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qvieM-0004qz-9r; Wed, 25 Oct 2023 14:30:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvieF-0004pv-VT for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 14:30:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qvieF-0006JJ-NH for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 14:30:31 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qviej-0007rq-Pk for bug-gnu-emacs@gnu.org; Wed, 25 Oct 2023 14:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Oct 2023 18:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66655 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 66655-submit@debbugs.gnu.org id=B66655.169825863030183 (code B ref 66655); Wed, 25 Oct 2023 18:31:01 +0000 Original-Received: (at 66655) by debbugs.gnu.org; 25 Oct 2023 18:30:30 +0000 Original-Received: from localhost ([127.0.0.1]:60026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvieE-0007ql-41 for submit@debbugs.gnu.org; Wed, 25 Oct 2023 14:30:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qvie9-0007qV-CH for 66655@debbugs.gnu.org; Wed, 25 Oct 2023 14:30:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qvidY-0005xf-QX; Wed, 25 Oct 2023 14:29:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4ZlA1OIcUCHhWzu1SmEVkM+LeT9gShQ5Im0QOwezzxQ=; b=ms0EPd77QEaf YBA0J2shUNRUpghfQCjV3DuoeUX3nsNiJuuPfjKsHeRlMY0Xu0hv3v/IiwPkuMZeiCoECXToujXRy KrqJFfChjj7uuJri0WV6rlcK6DPTLpENL2i0Y/Fosp/6FdMDNHBcqg+7AmNLIbz1bxNArcTuJuoOO 5o8nqOYxOztypXuGJuuRQyTc2aWl5OVk/w7ZvWDGnn/Z8DF6MK+uGKuvNxfuaOcDQqzry2ZhuIUhD ckzz/6HIKg4m8dXpD3ZmWIvQsXdIPOH2vmcU6vlmopNb+8Z+kBf9cg2uARg1ydKSLI2w4LTpFG36e S7hJbxIx34f0DuEroXHEug==; In-Reply-To: (message from Stefan Monnier on Wed, 25 Oct 2023 13:27:31 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273209 Archived-At: > From: Stefan Monnier > Cc: tomasralph2000@gmail.com, 66655@debbugs.gnu.org > Date: Wed, 25 Oct 2023 13:27:31 -0400 > > > But then we are back at the problem which the buffer-position check > > tries to address: > > > > /* Maybe the mouse has moved a lot, caused scrolling, and > > eventually ended up at the same screen position (but > > not buffer position) in which case it is a drag, not > > a click. */ > > > > IOW, just testing the screen coordinates is not enough. > > In my "in short is approximately" I used `mouse_has_moved` but that > was an oversimplification: in the new code `mouse_has_moved` doesn't > revert to "false" when the mouse returns to the original position, > contrary to what happen in the current code. How exactly does that happen? > The comment above talks about buffer positions (i.e. the Fcar+Fcdr > part of the positions), whereas this `EQ` tests the windows, and the > only relevant comment I see is > > /* Different window */ > > which reminds the reader that it's comparing windows but doesn't say why. > Did I miss something? Yes: we can be at the same buffer position, but a different window.