From: "Harald Jörg" <haj@posteo.de>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 43622@debbugs.gnu.org
Subject: bug#43622: 28.0.50; [CLEANUP][PATCH] cperl-mode: Eliminate dead code
Date: Sat, 26 Sep 2020 16:42:39 +0200 [thread overview]
Message-ID: <83fc51ad-82cb-0969-4777-1683025b0bba@posteo.de> (raw)
In-Reply-To: <87k0wglk51.fsf@gnus.org>
Lars Ingebrigtsen writes:
> Harald Jörg <haj@posteo.de> writes:
>
>> As recently discussed on the emacs-devel list, I'd like to eradicate
>> conditional code from cperl-mode where the conditionals evaluate to nil.
>>
>> [...]
>
> Looks good, so I've applied it to Emacs 28 with one change:
>
> In end of data:
> progmodes/cperl-mode.el:8525:1: Warning: the function `cperl-init-faces-weak'
> is not known to be defined.
>
> This function was removed, but the call wasn't, so I removed it (and
> changed the surrounding code slightly). If you could check that I
> didn't mess up that bit, that'd be nice.
Ouch - my bad. I missed to apply that hunk. I had a solution with the
same logic, but less elegant (closer to the original). Many thanks for
spotting this!
--
Cheers,
haj
prev parent reply other threads:[~2020-09-26 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 0:35 bug#43622: 28.0.50; [CLEANUP][PATCH] cperl-mode: Eliminate dead code Harald Jörg
2020-09-26 13:53 ` Lars Ingebrigtsen
2020-09-26 14:42 ` Harald Jörg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fc51ad-82cb-0969-4777-1683025b0bba@posteo.de \
--to=haj@posteo.de \
--cc=43622@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).