From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#7167: 23.2; w32-shell-execute doc Date: Fri, 08 Oct 2010 11:52:47 +0200 Message-ID: <83eic1nh8w.fsf@gnu.org> References: <4CAD419F.3020305@gmail.com> <4CAD4510.4000702@gmail.com> <83pqvloork.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1286533397 6584 80.91.229.12 (8 Oct 2010 10:23:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 8 Oct 2010 10:23:17 +0000 (UTC) Cc: cschol2112@googlemail.com, lekktu@gmail.com, sean.sieger@gmail.com, 7167-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 08 12:23:15 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P49yy-0003OZ-P1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Oct 2010 12:23:12 +0200 Original-Received: from localhost ([127.0.0.1]:39503 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P49yn-0002nO-5r for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Oct 2010 06:15:09 -0400 Original-Received: from [140.186.70.92] (port=55105 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P49vs-00023h-BD for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2010 06:14:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P49vj-0004i7-8a for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2010 06:12:00 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P49vj-0004i1-5h for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2010 06:11:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P49bS-000080-Ib for bug-gnu-emacs@gnu.org; Fri, 08 Oct 2010 05:51:02 -0400 Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Oct 2010 09:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 7167 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Mail-Followup-To: 7167@debbugs.gnu.org, eliz@gnu.org Original-Received: via spool by 7167-done@debbugs.gnu.org id=D7167.1286531404482 (code D ref 7167); Fri, 08 Oct 2010 09:51:02 +0000 Original-Received: (at 7167-done) by debbugs.gnu.org; 8 Oct 2010 09:50:04 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P49aW-00007j-AI for submit@debbugs.gnu.org; Fri, 08 Oct 2010 05:50:04 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P49aS-00007K-Pw for 7167-done@debbugs.gnu.org; Fri, 08 Oct 2010 05:50:02 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L9Y00K00U3DSM00@a-mtaout23.012.net.il> for 7167-done@debbugs.gnu.org; Fri, 08 Oct 2010 11:52:49 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([84.229.148.82]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L9Y00KPDU3YE7E0@a-mtaout23.012.net.il>; Fri, 08 Oct 2010 11:52:48 +0200 (IST) In-reply-to: <83pqvloork.fsf@gnu.org> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 08 Oct 2010 05:51:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40766 Archived-At: > Date: Thu, 07 Oct 2010 20:12:47 +0200 > From: Eli Zaretskii > Cc: cschol2112@googlemail.com, sean.sieger@gmail.com, 7167@debbugs.gnu.org > > > From: Juanma Barranquero > > Date: Thu, 7 Oct 2010 12:15:55 +0200 > > Cc: Sean Sieger , 7167@debbugs.gnu.org > > > > [Sean, I've Cc:ed you because you're doing binary tarballs now] > > > > On Thu, Oct 7, 2010 at 05:57, Christoph wrote: > > > > > Juanma, let me know if I can help troubleshoot this. > > > > I think it is an issue with the binary distribution of Emacs 23.2 for > > Windows, not with 23.2 per se, because I have my own build of it and > > the problem is not present. > > > > Likely the fix will simply be to rebuild the official binary > > distribution of 23.2. > > Not sure, because my binary, which I built myself, also has this > problem. > > Will try to investigate tomorrow. Found the problem. There's nothing wrong with the Windows build system per se. The problem is that emacs-23.2 tarball comes with a src/buildobj.h from a Unix system where it was tarred, which is baaaaad, and not only on Windows. This causes Make not to create src/buildobj.h as suitable for the actual build on the target platform, and the rest is history. I've just installed a fix in the emacs-23 branch (revno 100091 and a followup change in 100092) to exclude this file from the tarball. To fix this locally, just remove src/buildobj.h and rebuild Emacs. While at that, I would suggest that this code in help-fns.el: (let ((file (catch 'loop (while t (let ((pnt (search-forward (concat "" name "\n")))) (re-search-backward "S\\(.*\\)") (let ((file (match-string 1))) (if (member file build-files) (throw 'loop file) (goto-char pnt)))))))) (if (string-match "^ns.*\\(\\.o\\|obj\\)\\'" file) (setq file (replace-match ".m" t t file 1)) (if (string-match "\\.\\(o\\|obj\\)\\'" file) (setq file (replace-match ".c" t t file)))) (if (string-match "\\.\\(c\\|m\\)\\'" file) (concat "src/" file) file))))) be made smarter wrt the error message it displays when the function or variable it looks for is found in etc/DOC, but the file in which it is defined is not in build-files. (This happens when you click or type RET on the link to the source file where the function is defined.) Currently, the error message, which comes from search-forward, is quite cryptic for a naive user: Search failed: "^_Fw32-shell-execute " It should at least mention the fact that the problem could be with build-files, or, better, say that w32-shell-execute's definition is in a file that is not in build-files. Volunteers are welcome to make this improvement.