From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@jurta.org>
Cc: 9800@debbugs.gnu.org
Subject: bug#9800: Incomplete truncated file buffers from the /proc filesystem
Date: Thu, 20 Oct 2011 10:22:43 +0200 [thread overview]
Message-ID: <83ehy8t6lo.fsf@gnu.org> (raw)
In-Reply-To: <877h40vb8h.fsf@mail.jurta.org>
> From: Juri Linkov <juri@jurta.org>
> Date: Thu, 20 Oct 2011 01:59:42 +0300
>
> Large files from the /proc filesystem are visited incompletely,
> their file buffers are truncated at the position 65536.
> One possible test case to reproduce this is to load enough libraries
> with e.g. (imagemagick-register-types) and visit Emacs's maps file
> in /proc/$PID/maps.
>
> Andreas said in http://lists.gnu.org/archive/html/emacs-devel/2011-10/msg00782.html
> that it's due to this code in `insert-file-contents':
>
> /* The file size returned from stat may be zero, but data
> may be readable nonetheless, for example when this is a
> file in the /proc filesystem. */
> if (end_offset == 0)
> end_offset = READ_BUF_SIZE;
>
> How this could be fixed? Should it keep reading while more data can be
> read from the file?
Does lseek work on these files? If so, we could use something like
lseek (fd, 0L, SEEK_END)
to find its size. Or we could treat those files as non-regular, where
we set end_offset to TYPE_MAXIMUM (off_t) -- would that work with
these files?
next prev parent reply other threads:[~2011-10-20 8:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 22:59 bug#9800: Incomplete truncated file buffers from the /proc filesystem Juri Linkov
2011-10-20 8:22 ` Eli Zaretskii [this message]
2011-10-20 8:44 ` Andreas Schwab
2023-02-12 7:38 ` Eli Zaretskii
2023-02-12 9:24 ` Ruijie Yu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2011-10-24 2:53 ` Paul Eggert
2011-10-24 21:50 ` Richard Stallman
2011-10-24 22:02 ` Paul Eggert
2023-02-12 10:21 ` Arsen Arsenović via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-13 20:47 ` Paul Eggert
2011-11-03 20:32 ` Lars Magne Ingebrigtsen
2011-11-04 9:36 ` Juri Linkov
2011-11-04 10:54 ` Eli Zaretskii
2022-02-07 0:10 ` Lars Ingebrigtsen
2022-02-07 19:41 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ehy8t6lo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=9800@debbugs.gnu.org \
--cc=juri@jurta.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).