From: Eli Zaretskii <eliz@gnu.org>
To: Michael Welsh Duggan <mwd@cert.org>
Cc: ari.roponen@gmail.com, 11464@debbugs.gnu.org
Subject: bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text
Date: Fri, 18 May 2012 10:42:35 +0300 [thread overview]
Message-ID: <83ehqindec.fsf@gnu.org> (raw)
In-Reply-To: <tnthavelcyr.fsf@waterbuck.yellow.cert.org>
> From: Michael Welsh Duggan <mwd@cert.org>
> Cc: ari.roponen@gmail.com, 11464@debbugs.gnu.org
> Date: Thu, 17 May 2012 17:22:36 -0400
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> From: Michael Welsh Duggan <mwd@cert.org>
> >> Cc: Ari Roponen <ari.roponen@gmail.com>, 11464@debbugs.gnu.org
> >> Date: Thu, 17 May 2012 13:56:45 -0400
> >>
> >> else if (top_y < it.last_visible_y) ==> if (255 < 256) ==> if (TRUE)
> >>
> >> hence, visible_p _would_ be set to 1 by the else if clause.
> >
> > And will never be reset to zero, because 27 <= 256 => FALSE. And yet
> > Ari said that he needed to change the condition to <=.
>
> But where do you get 27? The number was 270, I believe.
It's 270, yes. But the rest is correct: if visible_p is set in this
case, it will never be reset with the current code. My original code
used
if (bottom_y >= it.last_visible_y
which would have caught this case.
Ari, can you please describe again what happens in this particular
case on your machine, step by step, when you step with a debugger
through the relevant fragment?
I'm sorry I keep asking questions, but I must understand what was
incorrect in my original reasoning, to make sure there's no subtle
bugs lurking here.
Also, for this case:
> bottom_y = 300
> it.last_visible_y = 304
can you show the corresponding values of top_y and window_top_y?
Thanks.
next prev parent reply other threads:[~2012-05-18 7:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 15:54 bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text Ari Roponen
2012-05-13 18:26 ` Eli Zaretskii
2012-05-15 10:07 ` Ari Roponen
2012-05-15 16:19 ` Eli Zaretskii
2012-05-16 5:21 ` Ari Roponen
2012-05-16 15:15 ` Eli Zaretskii
2012-05-17 4:52 ` Ari Roponen
2012-05-17 16:23 ` Eli Zaretskii
2012-05-17 17:54 ` Ari Roponen
2012-05-17 17:56 ` Michael Welsh Duggan
2012-05-17 21:11 ` Eli Zaretskii
2012-05-17 21:22 ` Michael Welsh Duggan
2012-05-18 7:42 ` Eli Zaretskii [this message]
2012-05-18 8:03 ` Ari Roponen
2012-05-18 8:26 ` Ari Roponen
2012-05-18 8:44 ` Eli Zaretskii
2012-05-18 10:47 ` Ari Roponen
2012-05-18 11:32 ` Eli Zaretskii
2012-05-18 11:47 ` Ari Roponen
2012-05-18 14:02 ` Eli Zaretskii
2012-05-18 14:39 ` Ari Roponen
2012-05-18 14:59 ` Eli Zaretskii
2012-05-19 12:26 ` Eli Zaretskii
2012-05-19 12:32 ` Ari Roponen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ehqindec.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=11464@debbugs.gnu.org \
--cc=ari.roponen@gmail.com \
--cc=mwd@cert.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).