From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 13026@debbugs.gnu.org
Subject: bug#13026: Assume POSIX 1003.1-1988 or later for signal.h.
Date: Fri, 30 Nov 2012 10:54:11 +0200 [thread overview]
Message-ID: <83ehjbv5cc.fsf@gnu.org> (raw)
In-Reply-To: <50B7D5BC.5060606@cs.ucla.edu>
> Date: Thu, 29 Nov 2012 13:38:04 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: 13026@debbugs.gnu.org
>
> > This will break the Windows build in more than one way, unless
> > accompanied by suitable Windows-only changes. Is this the entire
> > changeset, or did you omit some more changes?
>
> That was the entire changeset. I didn't know about the problems
> on MS-Windows. I trimmed down the patch, to avoid the issues you
> raised, and am attaching a proposed revised patch. Thanks for
> the review.
Thanks, this looks fine, except for this part:
> @@ -5992,8 +5978,6 @@
> if (!strncmp (name, "SIG", 3) || !strncmp (name, "sig", 3))
> name += 3;
>
> - if (0)
> - ;
> #ifdef SIGUSR1
> parse_signal ("usr1", SIGUSR1);
> #endif
The expansion of parse_signal starts with "else if", so it looks like
removing that ugly "if (0)" will break something like
M-: (signal-process 'SIGINT) RET
because the unrelated 'if' before it will then be used to do nothing
useful with such signal specs. Maybe a better fix there would be to
have an array of data (name and value of each signal), and loop
through it, instead of using if-elseif.
By the way, an alternative way of dealing with the lack of Posix
signals on Windows is to condition the related fragments on WINDOWSNT,
and remove the "#ifdef SIGFOO" conditions for Posix signals. That
would tell more clearly why the code is being excluded, I think.
next prev parent reply other threads:[~2012-11-30 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 6:52 bug#13026: Assume POSIX 1003.1-1988 or later for signal.h Paul Eggert
2012-11-29 17:33 ` Eli Zaretskii
2012-11-29 21:38 ` Paul Eggert
2012-11-30 8:54 ` Eli Zaretskii [this message]
2012-12-03 1:31 ` Paul Eggert
2012-12-04 19:17 ` Eli Zaretskii
2012-12-08 2:40 ` Paul Eggert
2012-12-08 10:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ehjbv5cc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13026@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).