From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#14295: Support copy-file ACLs for Solaris etc. Date: Mon, 29 Apr 2013 20:07:43 +0300 Message-ID: <83ehdtqn8g.fsf@gnu.org> References: <517C987F.6060902@cs.ucla.edu> <83ehdushhu.fsf@gnu.org> <517E0FEA.2000500@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1367255338 32299 80.91.229.3 (29 Apr 2013 17:08:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Apr 2013 17:08:58 +0000 (UTC) Cc: 14295@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 29 19:08:57 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UWrZO-0000x3-DL for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2013 19:08:54 +0200 Original-Received: from localhost ([::1]:57782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrZN-0001KB-P4 for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Apr 2013 13:08:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrZJ-0001Js-HA for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 13:08:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWrZD-0006WC-Ln for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 13:08:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46531) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrZD-0006W6-J5 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 13:08:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UWrZV-0003jU-Le for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 13:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Apr 2013 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.136725530614182 (code B ref -1); Mon, 29 Apr 2013 17:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 Apr 2013 17:08:26 +0000 Original-Received: from localhost ([127.0.0.1]:50639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWrYw-0003gf-0g for submit@debbugs.gnu.org; Mon, 29 Apr 2013 13:08:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48080) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UWrYt-0003gS-Oj for submit@debbugs.gnu.org; Mon, 29 Apr 2013 13:08:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWrYZ-0006Kz-Rh for submit@debbugs.gnu.org; Mon, 29 Apr 2013 13:08:05 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:37808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrYZ-0006Kv-PD for submit@debbugs.gnu.org; Mon, 29 Apr 2013 13:08:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrYU-0000Ip-RW for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 13:08:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWrYP-0006IR-VS for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 13:07:58 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:46846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWrYP-0006Go-N5 for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 13:07:53 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MM000900ZSE1Z00@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Mon, 29 Apr 2013 20:07:52 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MM1009FS0X36Z30@a-mtaout20.012.net.il>; Mon, 29 Apr 2013 20:07:52 +0300 (IDT) In-reply-to: <517E0FEA.2000500@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:73829 Archived-At: > Date: Sun, 28 Apr 2013 23:15:06 -0700 > From: Paul Eggert > CC: bug-gnu-emacs@gnu.org > > > How hard would it to support both? > > I don't know, and I'd rather not support --without-acl. This should > have been an --enable/--disable option in the first place, as it's > enabling or disabling a feature, not building with or without a > package. There's little point to Emacs departing from existing > GNU practice here. I just wonder how many people are used to that option. Maybe not too many, since this is a new feature. > > This uses EOPNOTSUPP without #ifdef guards; is that universally > > available? > > Mostly, except for Windows, but to play it safe we can incorporate the > Gnulib errno module, which defines EOPNOTSUPP if it's not already > defined. That almost works, but there are 2 issues: . I'd prefer to have the definition of EOPNOTSUPP in nt/inc/ms-w32.h, to make synchronization of config.nt with src/config.in easier. . More importantly, ENOTSUP is defined on Windows with the same value as ENOSYS (see ms-w32.h), so acl-errno-valid.c will fail to compile due to 2 identical case values in a switch. > > If I'm right, perhaps it is best to leave the WINDOWSNT parts alone: > > Sure, we can do that. Thanks. > OK. Revised patch attached, which tries to address the above. It looks fine, other than the 2 minor issues above, thanks. > It relies on Gnulib for EOPNOTSUPP, except for WINDOWSNT where > 'configure' isn't working yet, and there it adds a line to > nt/config.nt to deal with this until we get 'configure' working. 'configure' is already working, I just need time to finish up the branch and merge it. But even when that is done (hopefully in a few days), we will not immediately abandon the current configury. It will take some time.