From: Eli Zaretskii <eliz@gnu.org>
To: rgm@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
Kenichi Handa <handa@gnu.org>
Cc: 15260@debbugs.gnu.org
Subject: bug#15260: cannot build in a directory with non-ascii characters
Date: Sun, 27 Oct 2013 21:02:51 +0200 [thread overview]
Message-ID: <83eh76fsf8.fsf@gnu.org> (raw)
In-Reply-To: <83k3gyfzzk.fsf@gnu.org>
The first few problems that pop up when building from the source tree
whose parent has a non-ASCII name are solved by the changes below.
I'm not very fond of these changes, especially the last one: it all
looks very fragile and ad-hoc, and that's still on a system with a
UTF-8 locale, where things should be relatively easy.
After applying these changes, temacs comes up and dumps itself, but
fails to find simple.el and bytecomp.el when it proceeds to compiling
Lisp files. I guess now load-path is the culprit.
Stay tuned.
=== modified file 'lisp/loadup.el'
--- lisp/loadup.el 2013-10-08 15:11:29 +0000
+++ lisp/loadup.el 2013-10-27 18:26:12 +0000
@@ -150,7 +150,9 @@
(load "epa-hook")
;; Any Emacs Lisp source file (*.el) loaded here after can contain
;; multilingual text.
-(load "international/mule-cmds")
+(let ((dfn-coding default-file-name-coding-system))
+ (load "international/mule-cmds")
+ (setq default-file-name-coding-system dfn-coding))
(load "case-table")
;; This file doesn't exist when building a development version of Emacs
;; from the repository. It is generated just after temacs is built.
@@ -163,7 +165,9 @@
(load "language/cyrillic")
(load "language/indian")
(load "language/sinhala")
-(load "language/english")
+(let ((dfn-coding default-file-name-coding-system))
+ (load "language/english")
+ (setq default-file-name-coding-system dfn-coding))
(load "language/ethiopic")
(load "language/european")
(load "language/czech")
=== modified file 'src/emacs.c'
--- src/emacs.c 2013-10-26 13:43:58 +0000
+++ src/emacs.c 2013-10-27 18:48:51 +0000
@@ -2044,14 +2044,22 @@ You must run Emacs in batch mode in orde
CHECK_STRING (filename);
filename = Fexpand_file_name (filename, Qnil);
- filename = ENCODE_FILE (filename);
+ if (NILP (Vfile_name_coding_system)
+ && NILP (Vdefault_file_name_coding_system))
+ filename = Fstring_to_unibyte (filename);
+ else
+ filename = ENCODE_FILE (filename);
if (!NILP (symfile))
{
CHECK_STRING (symfile);
if (SCHARS (symfile))
{
symfile = Fexpand_file_name (symfile, Qnil);
- symfile = ENCODE_FILE (symfile);
+ if (NILP (Vfile_name_coding_system)
+ && NILP (Vdefault_file_name_coding_system))
+ symfile = Fstring_to_unibyte (symfile);
+ else
+ symfile = ENCODE_FILE (symfile);
}
}
next prev parent reply other threads:[~2013-10-27 19:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 17:46 bug#15260: cannot build in a directory with non-ascii characters Glenn Morris
2013-10-23 20:48 ` Glenn Morris
2013-10-24 18:25 ` Eli Zaretskii
2013-10-24 18:35 ` Glenn Morris
2013-10-25 14:25 ` Eli Zaretskii
2013-10-25 17:08 ` Glenn Morris
2013-10-25 18:31 ` Eli Zaretskii
2013-10-25 18:40 ` Glenn Morris
2013-10-25 18:46 ` Eli Zaretskii
2013-10-25 19:27 ` Eli Zaretskii
2013-10-26 7:50 ` Eli Zaretskii
2013-10-26 19:15 ` Glenn Morris
2013-10-26 20:04 ` Eli Zaretskii
2013-10-27 3:56 ` Eli Zaretskii
2013-10-27 16:19 ` Eli Zaretskii
2013-10-27 19:02 ` Eli Zaretskii [this message]
2013-10-27 19:43 ` Eli Zaretskii
2013-10-27 4:28 ` Stefan Monnier
2013-10-27 16:11 ` Eli Zaretskii
2013-10-28 0:30 ` Stefan Monnier
2013-10-28 3:39 ` Eli Zaretskii
2013-10-28 4:05 ` Stefan Monnier
2013-10-28 16:47 ` Eli Zaretskii
2013-10-28 18:33 ` Eli Zaretskii
2013-10-28 22:00 ` Glenn Morris
2013-10-29 3:42 ` Eli Zaretskii
2013-10-29 1:35 ` Stefan Monnier
2013-10-29 3:47 ` Eli Zaretskii
2013-10-29 13:56 ` Stefan Monnier
2013-10-30 18:19 ` Eli Zaretskii
2013-10-31 1:01 ` Stefan Monnier
2013-10-31 3:47 ` Eli Zaretskii
2013-10-31 13:40 ` Stefan Monnier
2013-10-31 16:25 ` Eli Zaretskii
2013-10-31 18:04 ` Stefan Monnier
2013-10-31 17:59 ` Eli Zaretskii
2013-10-31 19:24 ` Stefan Monnier
2013-10-31 19:33 ` Eli Zaretskii
2013-11-01 9:27 ` Eli Zaretskii
2013-11-01 12:33 ` Stefan Monnier
2013-11-04 17:37 ` Eli Zaretskii
2013-11-04 17:35 ` Eli Zaretskii
2013-11-04 18:38 ` Stefan Monnier
2013-10-31 17:16 ` Eli Zaretskii
2013-10-31 18:09 ` Stefan Monnier
2013-10-31 18:37 ` Eli Zaretskii
2013-10-31 19:41 ` Eli Zaretskii
2013-11-01 13:58 ` Kenichi Handa
2013-10-31 21:45 ` Glenn Morris
2013-11-01 7:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83eh76fsf8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=15260@debbugs.gnu.org \
--cc=handa@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).