From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18112: 24.4.50; emacs --daemon infinite loop in find_interval Date: Fri, 08 Aug 2014 13:40:30 +0300 Message-ID: <83egwrmfhd.fsf@gnu.org> References: <877g31dojo.fsf@holos.localdomain> <83k370ipta.fsf@gnu.org> <83iomkimg0.fsf@gnu.org> <83fvhoij80.fsf@gnu.org> <83egx8ihw5.fsf@gnu.org> <8361ijhryg.fsf@gnu.org> <53D50029.9020802@gmx.at> <831tt6j1gk.fsf@gnu.org> <53E4A1FA.9090902@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1407494486 28868 80.91.229.3 (8 Aug 2014 10:41:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Aug 2014 10:41:26 +0000 (UTC) Cc: mvoteiza@udel.edu, 18112@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 08 12:41:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XFhbp-0002Hk-B0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Aug 2014 12:41:17 +0200 Original-Received: from localhost ([::1]:50358 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFhbo-0008Hb-Ia for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Aug 2014 06:41:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFhbg-0008GV-Ru for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 06:41:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFhbc-0003wc-4V for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 06:41:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFhbc-0003w4-20 for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 06:41:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XFhbb-0007n4-9x for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 06:41:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Aug 2014 10:41:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18112 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18112-submit@debbugs.gnu.org id=B18112.140749444729896 (code B ref 18112); Fri, 08 Aug 2014 10:41:03 +0000 Original-Received: (at 18112) by debbugs.gnu.org; 8 Aug 2014 10:40:47 +0000 Original-Received: from localhost ([127.0.0.1]:34698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFhbK-0007m5-6y for submit@debbugs.gnu.org; Fri, 08 Aug 2014 06:40:46 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:56749) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFhbD-0007li-P6 for 18112@debbugs.gnu.org; Fri, 08 Aug 2014 06:40:41 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N9Z00700HCMEO00@mtaout25.012.net.il> for 18112@debbugs.gnu.org; Fri, 08 Aug 2014 13:35:39 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9Z001IJHFFE450@mtaout25.012.net.il>; Fri, 08 Aug 2014 13:35:39 +0300 (IDT) In-reply-to: <53E4A1FA.9090902@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92304 Archived-At: > Date: Fri, 08 Aug 2014 12:10:02 +0200 > From: martin rudalics > CC: 18112@debbugs.gnu.org, mvoteiza@udel.edu > > > As long as I have your attention: how about adding some comments > > and/or text to respective doc strings to explain what exactly the > > following functions do, and why/when are they needed? > > > > window-normal-size > > window-new-total > > window-new-normal > > window-new-pixel > > > > and the corresponding set-* functions. Their doc strings are just > > tautological repetition of their names, which isn't helpful. And the > > ELisp manual doesn't say a word about them, so the doc strings need to > > do a better job, IMO. > > I've tried to do that now. Please have a look. Thanks. This is an improvement for the functions that deal with the "normal" size (which should have been called "normalized", but I guess that's water under the bridge now). I see no improvement for the "total" size. The additions to the doc strings point to window-total-size, but that function's doc string does not explain what is the semantics of "total" in this respect. (The doc string of window-total-size references window-total-width and window-total-height, which do say something about that, but having to traverse more than 1 hyperlink to find the information is not a good idea, IMO.) Also, the way you document the *-new-* functions could be improved. You say something like The new pixel size of WINDOW is used by `window-resize-apply' and, if that function succeeds, will be subsequently returned by the functions `window-pixel-height' and `window-pixel-width'. I suggest instead to say something that describes the effect, but not how the effect is achieved (which is low-level information that obscures and obfuscates what the reader would like to know): The new pixel size of WINDOW, if it is valid, will be shortly installed as WINDOW's size. Thanks.