From: Eli Zaretskii <eliz@gnu.org>
To: handa@gnu.org (K. Handa)
Cc: dmantipov@yandex.ru, maden.ldm@gmail.com, 18610@debbugs.gnu.org
Subject: bug#18610: 24.4.50; Specific file causing emacs to segfault upon opening
Date: Mon, 06 Oct 2014 18:20:08 +0300 [thread overview]
Message-ID: <83egulmdhz.fsf@gnu.org> (raw)
In-Reply-To: <87a959ti1h.fsf@gnu.org>
> From: handa@gnu.org (K. Handa)
> Cc: dmantipov@yandex.ru, maden.ldm@gmail.com, 18610@debbugs.gnu.org
> Date: Mon, 06 Oct 2014 23:00:10 +0900
>
> In article <83zjdamrbd.fsf@gnu.org>, Eli Zaretskii <eliz@gnu.org> writes:
>
> > > No. Even if there's no special ISO-2022 escape sequence, we
> > > should not reject iso-2022 as a detected coding system.
>
> > Can you explain why? AFAICT, all the other detectors are required to
> > set some flag in the 'found' field, so why is ISO-2022 special in this
> > regard?
>
> Because the file contains the byte #x96 which is included in
> latin-extra-code-table (i.e. (aref latin-extra-code-table
> #x96) is t).
Yes, but what's the reason for having latin-extra-code-table in the
first place?
> > Btw, it would be nice if these masks could be documented so that their
> > meaning was clear. I considered the possibility that the flags are
> > not set correctly, but couldn't test that hypothesis given my
> > insufficient knowledge of ISO-2022 details and variants.
>
> Sorry for the poor comments in my code. I'll work on it soon.
TIA.
> > would set the buffer-file-coding-system of the buffer
> > visiting the file to 'undecided', and regarded the \226
> > characters as 8-bit raw bytes:
>
> I think that is a bug. If the file doesn't contain ESC, it
> is detected as latin-1. If the file contains latin-1 byte
> 0xA0..0xFF instead of \226, it is detected as latin-1. So,
> as far as \226 is treated as extra latin code, it should be
> decoded as latin-1.
OK. Do you think this fix is safe enough to go to the release branch,
so as to prevent Emacs 24.4 from crashing in these circumstances?
next prev parent reply other threads:[~2014-10-06 15:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 14:50 bug#18610: 24.4.50; Specific file causing emacs to segfault upon opening maden.ldm
2014-10-02 15:40 ` Nicolas Richard
2014-10-03 8:14 ` Eli Zaretskii
2014-10-03 11:22 ` Dmitry Antipov
2014-10-03 12:20 ` Eli Zaretskii
2014-10-03 12:39 ` Eli Zaretskii
2014-10-03 15:16 ` Andreas Schwab
2014-10-03 15:32 ` Eli Zaretskii
2014-10-03 16:02 ` Andreas Schwab
2014-10-03 16:35 ` Eli Zaretskii
2014-10-03 16:40 ` Andreas Schwab
2014-10-03 16:57 ` Eli Zaretskii
2014-10-05 8:59 ` K. Handa
2014-10-05 16:09 ` Eli Zaretskii
2014-10-06 14:00 ` K. Handa
2014-10-06 15:20 ` Eli Zaretskii [this message]
2014-10-07 12:34 ` K. Handa
2014-10-07 13:20 ` Ivan Shmakov
2014-10-07 14:33 ` Eli Zaretskii
2014-10-07 15:10 ` Ivan Shmakov
2014-10-07 15:19 ` Eli Zaretskii
2014-10-08 7:33 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83egulmdhz.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=18610@debbugs.gnu.org \
--cc=dmantipov@yandex.ru \
--cc=handa@gnu.org \
--cc=maden.ldm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).