From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#20895: [patch] lexical binding broke part of sgml-mode.el Date: Thu, 25 Jun 2015 17:34:31 +0300 Message-ID: <83egkzeu14.fsf@gnu.org> References: <87mvzoax2c.fsf@gmx.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1435242930 15058 80.91.229.3 (25 Jun 2015 14:35:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 25 Jun 2015 14:35:30 +0000 (UTC) Cc: 20895@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 25 16:35:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z88FK-00013H-NY for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jun 2015 16:35:18 +0200 Original-Received: from localhost ([::1]:56023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z88FK-0000cV-4u for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jun 2015 10:35:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z88FB-0000VZ-CU for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 10:35:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z88F6-00024C-Hg for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 10:35:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55898) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z88F6-00023s-Ey for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 10:35:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z88F6-0003zW-6n for bug-gnu-emacs@gnu.org; Thu, 25 Jun 2015 10:35:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jun 2015 14:35:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20895 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 20895-submit@debbugs.gnu.org id=B20895.143524289615319 (code B ref 20895); Thu, 25 Jun 2015 14:35:04 +0000 Original-Received: (at 20895) by debbugs.gnu.org; 25 Jun 2015 14:34:56 +0000 Original-Received: from localhost ([127.0.0.1]:57343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z88Ex-0003z0-IS for submit@debbugs.gnu.org; Thu, 25 Jun 2015 10:34:56 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:52082) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z88Ev-0003yk-6e for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 10:34:54 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NQI001007VASY00@mtaout24.012.net.il> for 20895@debbugs.gnu.org; Thu, 25 Jun 2015 17:26:02 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NQI000CH83EC520@mtaout24.012.net.il>; Thu, 25 Jun 2015 17:26:02 +0300 (IDT) In-reply-to: <87mvzoax2c.fsf@gmx.net> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104336 Archived-At: > From: Stephen Berman > Date: Thu, 25 Jun 2015 12:42:35 +0200 > > The following change broke some functionality in sgml-mode.el: > > commit 84e0b7dad6f1a8e53261f9b96f5a9080fea681a4 > Author: Stefan Monnier > Date: Mon Apr 13 15:51:15 2015 -0400 > [...] > * lisp/textmodes/sgml-mode.el: Use lexical-binding. > > To see the bug, visit an (X)HTML file and insert a tag (`C-c C-t') that > takes an attribute, such `p' or `a'. > > The following patch fixes the problems I have encountered, but I'm not > sure if further adjustments are needed, so I'll defer to whoever knows > the code better about whether to commit it as is. Whatever comes out of this discussion, would you please consider adding a suitable test to sgml-mode-tests.el? TIA.