unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 21998@debbugs.gnu.org, johnw@gnu.org
Subject: bug#21998: Run 'make change-history' on release branch
Date: Tue, 08 Mar 2016 18:08:15 +0200	[thread overview]
Message-ID: <83egblrlzk.fsf@gnu.org> (raw)
In-Reply-To: <snd1r5jugz.fsf@fencepost.gnu.org> (message from Glenn Morris on Tue, 08 Mar 2016 02:32:12 -0500)

> From: Glenn Morris <rgm@gnu.org>
> Cc: John Wiegley <johnw@gnu.org>,  21998@debbugs.gnu.org
> Date: Tue, 08 Mar 2016 02:32:12 -0500
> 
> > I think if we care at all about having ChangeLog in the releases, we
> > should simply reinstate the file and maintain it in the repository.
> 
> FWIW, that's not what I was hoping would come from this, and I think
> that would be a retrograde step.

Can you tell why?  It solves all the problems you mention in your
mail, at negligible costs.  So it seems to be a clear winner.

> For 1) and 2), experience shows that few people will bother to make
> corrections.

Is it an important drawback that few people bother to make
corrections?  If it is, then any solution that involves such
corrections is not what we want.

Also, is the situation with corrections worse or better than what it
was when we maintained ChangeLog files in the repository?

> PS For the record, to explain the actual merging issue as I see it:
> 
> Suppose emacs-25 and master are synced at revision aaa and ChangeLog.2
> is up-to-date. emacs-25 advances to rev xxx, and independently master to
> rev xxx'. emacs-25 gets ChangeLog.2 updated, and merged to master. Now
> the footer of master ChangeLog.2 reports that it is up-to-date to rev
> xxx. What does this mean for the changes on master between aaa and xxx'?
> Because xxx on master is "after" xxx', I suspect it means they end up
> missing from ChangeLog.2 forever, which is bad.

No, they don't end up missing.  They will in general be in the "wrong"
order, time-wise, though.  But what is the "right" order for this
situation, where changes are made in parallel on several branches?  Do
we want them interwoven, in strict order of their commit times?  Or do
we want all the entries of a merge from the branch be kept together
with the time stamp of the merge?  If we want to continue keeping a
single generated ChangeLog file on master and on the branch, we need
to decide what is the desired result.

> But maybe there's no such issue, or it is fixable with some git
> trivia.

The only "git trivia" that's possible is a custom merge driver (which
AFAIK doesn't exist).  Git itself is not aware of the special meaning
of the time stamps in ChangeLog entries.

We could also have some Lisp rearranging the entries in whatever order
we decide we want it, after git-merge-changelog puts them in the order
it thinks is right.

> I don't know. That's why I made this bug report. AFAICS, the adopted
> "solution" was simply to ignore the issue, which means
> master/ChangeLog.2 is (probably) messed up at the moment.

It is not messed, but it isn't in chronological order, either.  And it
looks like no one ran "make change-history" on master for several
moons, so problems might become worse when they do.





  reply	other threads:[~2016-03-08 16:08 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 19:08 bug#21998: Run 'make change-history' on release branch Glenn Morris
2016-02-13  0:52 ` Paul Eggert
2016-02-16 16:41   ` Glenn Morris
2016-02-16 17:54     ` Paul Eggert
2016-03-04 16:46     ` Glenn Morris
2016-03-05 19:11       ` Eli Zaretskii
2016-03-06  9:47         ` Lars Magne Ingebrigtsen
2016-03-06 18:02           ` Dmitry Gutov
2016-03-06 21:07           ` John Wiegley
2016-03-06 21:25             ` Ingo Lohmar
2016-03-06 21:52               ` bug#21998: Is it time to drop ChangeLogs? (Was: bug#21998: Run 'make change-history' on release branch) John Wiegley
     [not found]               ` <m2oaarxojf.fsf_-_@newartisans.com>
2016-03-06 22:05                 ` Eric S. Raymond
2016-03-06 22:34                 ` Paul Eggert
2016-03-06 23:06                 ` Drew Adams
     [not found]                 ` <64a52598-ad53-498c-993c-67d7827dbdfc@default>
2016-03-07  0:15                   ` bug#21998: Is it time to drop ChangeLogs? John Wiegley
     [not found]                   ` <m2io0zw3cd.fsf@newartisans.com>
2016-03-07  0:24                     ` Drew Adams
2016-03-07  0:22                 ` Mathieu Lirzin
     [not found]                 ` <87vb4zb0i4.fsf@gnu.org>
2016-03-07  1:19                   ` Eric S. Raymond
2016-03-07  9:29                 ` Alan Mackenzie
     [not found]                 ` <56DCB064.9060206@cs.ucla.edu>
2016-03-07 16:26                   ` bug#21998: Is it time to drop ChangeLogs? (Was: bug#21998: Run 'make change-history' on release branch) Eli Zaretskii
2016-03-08  7:32         ` bug#21998: Run 'make change-history' on release branch Glenn Morris
2016-03-08 16:08           ` Eli Zaretskii [this message]
2016-03-07  6:51       ` Richard Stallman
2016-03-07 16:02         ` Eli Zaretskii
2016-03-07 16:35           ` John Wiegley
2016-03-07 17:00             ` Eli Zaretskii
2016-03-07 17:51               ` John Wiegley
2016-03-08 18:23           ` Richard Stallman
2016-03-08 18:30             ` Eli Zaretskii
2016-03-09 16:38               ` Richard Stallman
2016-03-09 16:51                 ` Eli Zaretskii
2016-03-10 21:23                   ` Richard Stallman
2016-03-11  8:48                     ` Eli Zaretskii
2016-03-11 10:05       ` Nicolas Petton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83egblrlzk.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21998@debbugs.gnu.org \
    --cc=johnw@gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).