From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Date: Sun, 29 May 2016 17:42:13 +0300 Message-ID: <83eg8lx6wq.fsf@gnu.org> References: <87d1o52ntu.fsf@gmx.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1464533005 10863 80.91.229.3 (29 May 2016 14:43:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 May 2016 14:43:25 +0000 (UTC) Cc: 23647@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 29 16:43:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b71vu-0006D6-2v for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2016 16:43:14 +0200 Original-Received: from localhost ([::1]:56071 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71vt-0003ur-5x for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 May 2016 10:43:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71vm-0003iJ-ME for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:43:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71vi-0000T3-F6 for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:43:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71vi-0000Sz-C3 for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b71vi-0001fg-7M for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2016 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23647-submit@debbugs.gnu.org id=B23647.14645329316360 (code B ref 23647); Sun, 29 May 2016 14:43:02 +0000 Original-Received: (at 23647) by debbugs.gnu.org; 29 May 2016 14:42:11 +0000 Original-Received: from localhost ([127.0.0.1]:46534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71us-0001eW-NG for submit@debbugs.gnu.org; Sun, 29 May 2016 10:42:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71ur-0001eF-9k for 23647@debbugs.gnu.org; Sun, 29 May 2016 10:42:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71ui-0000Hu-Sw for 23647@debbugs.gnu.org; Sun, 29 May 2016 10:42:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71ui-0000Hj-QF; Sun, 29 May 2016 10:42:00 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3115 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b71uh-0002H4-0x; Sun, 29 May 2016 10:41:59 -0400 In-reply-to: <87d1o52ntu.fsf@gmx.net> (message from Stephen Berman on Sun, 29 May 2016 11:52:29 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118832 Archived-At: > From: Stephen Berman > Date: Sun, 29 May 2016 11:52:29 +0200 > > O. emacs -Q > 1. Open a man page that has a link on a hyphenated word, e.g. on my > system: M-x man RET signal RET, put point on the word spanning lines > 129-130, which is displayed as `sig- > nalfd(2)'. > 2. Type RET (or click mouse-1 or mouse-2) on that link. > => The error message "Can’t find the 2 sig-nalfd manpage" is displayed. > > The following patch makes the link DTRT: > > diff --git a/lisp/man.el b/lisp/man.el > index 5acf90b..5d4cacc 100644 > --- a/lisp/man.el > +++ b/lisp/man.el > @@ -1430,8 +1430,14 @@ Man-bgproc-sentinel > (quit-restore-window > (get-buffer-window (current-buffer) t) 'kill) > (kill-buffer (current-buffer))) > - (message "Can't find the %s manpage" > - (Man-page-from-arguments args))) > + ;; Entries hyphenated due to the window width > + ;; won't be found in the man database, so remove > + ;; the hyphenation and look again. > + (if (string-match "-" args) Is it only the ASCII hyphen/minus, or could there be other characters (e.g., if Groff/troff are invoked with some exotic -Tfoo switch)? > This is a long-standing bug (presumably since commit > 162a12b1d7b1e985a8810bad24d068c825286f56 of Sep 13 2007), but although > the fix seems safe, I suppose it's too late for emacs-25. So if there > are no objections, should I commit it to master, or is it ok for the > upcoming release? Master, please. Thanks.