From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24939: [PATCH] Add tests for lisp/kmacro.el Date: Sat, 04 Feb 2017 13:57:16 +0200 Message-ID: <83efze88yr.fsf@gnu.org> References: <834m3ahxic.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1486209491 27286 195.159.176.226 (4 Feb 2017 11:58:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 4 Feb 2017 11:58:11 +0000 (UTC) Cc: 24939-done@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 04 12:58:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZyyk-0006sN-4B for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 12:58:06 +0100 Original-Received: from localhost ([::1]:38895 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyyp-0005d5-P0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 Feb 2017 06:58:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyyj-0005cn-CW for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:58:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZyyg-0006L6-9k for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:58:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57362) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cZyyg-0006Ks-6K for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cZyyg-0000kq-0T for bug-gnu-emacs@gnu.org; Sat, 04 Feb 2017 06:58:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2017 11:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 24939 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 24939@debbugs.gnu.org, eliz@gnu.org, gazally@runbox.com Original-Received: via spool by 24939-done@debbugs.gnu.org id=D24939.14862094562862 (code D ref 24939); Sat, 04 Feb 2017 11:58:01 +0000 Original-Received: (at 24939-done) by debbugs.gnu.org; 4 Feb 2017 11:57:36 +0000 Original-Received: from localhost ([127.0.0.1]:55560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZyyG-0000k6-9O for submit@debbugs.gnu.org; Sat, 04 Feb 2017 06:57:36 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:60604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZyyE-0000jt-IS for 24939-done@debbugs.gnu.org; Sat, 04 Feb 2017 06:57:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZyy6-00068q-4H for 24939-done@debbugs.gnu.org; Sat, 04 Feb 2017 06:57:29 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZyy6-00068l-14; Sat, 04 Feb 2017 06:57:26 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1421 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cZyy5-0006os-8j; Sat, 04 Feb 2017 06:57:25 -0500 In-reply-to: (message from Gemini Lasswell on Sat, 31 Dec 2016 09:42:25 -0800) X-detected-operating-system: by eggs.gnu.org: Error: Can't connect to API socket. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:128947 Archived-At: > From: Gemini Lasswell > Cc: 24939@debbugs.gnu.org > Date: Sat, 31 Dec 2016 09:42:25 -0800 > > Eli Zaretskii writes: > > Allow me a few comments to your proposed patch. > > Here is an updated version taking your comments into account. I was able > to remove the use of advice on all the functions in macros.c except for > end-kbd-macro, because I couldn't come up with another way to make > kmacro-end-macro recognize a keyboard macro defined by a test. > kmacro-end-macro tests last-kbd-macro right after it calls > end-kbd-macro, and end-kbd-macro is going to leave last-kbd-macro empty > unless it has something in current_kboard->kbd_macro_buffer, which Lisp > can't access. If there is another strategy you'd like me to try there, > let me know. Thanks, I pushed this now. > This patch contains kmacro-tests-with-message-capture which is the same > as the macro proposed as an addition to ert-x.el in bug#25158, so if > that patch is adopted, it could be removed from this patch. I've replaced the macro with ert-with-message-capture.