unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tino Calancha <tino.calancha@gmail.com>
Cc: 25618@debbugs.gnu.org
Subject: bug#25618: 25.1.91; More precise limit for tagging expensive tests
Date: Fri, 10 Feb 2017 10:49:38 +0200	[thread overview]
Message-ID: <83efz64ehp.fsf@gnu.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1702050250530.2283@calancha-pc> (message from Tino Calancha on Sun, 5 Feb 2017 02:54:03 +0900 (JST))

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 5 Feb 2017 02:54:03 +0900 (JST)
> cc: Tino Calancha <tino.calancha@gmail.com>, 25618@debbugs.gnu.org
> 
> On Sat, 4 Feb 2017, Eli Zaretskii wrote:
> 
> >> From: Tino Calancha <tino.calancha@gmail.com>
> >> Date: Sat, 04 Feb 2017 22:42:44 +0900
> >>
> >>
> >> Prefer set a numeric limit of seconds than using the word 'few'.
> >>
> >> For instance, in my box the test `cl-seq-test-bug24264' in
> >> test/lisp/emacs-lisp/cl-seq-tests.el
> >> takes 7 s.
> >> With an explicit numeric threshold is easier to decide whether this test
> >> must be tagged as expensive or not.
> >>
> >> In following patch i define a few as 2-3 seconds.  Other people might
> >> prefer 4-5 or even higher.
> >> Please, suggest a proper value to consider a test as expensive.
> >
> > I think 2-3 sec is negligible, and 7 sec is not long enough to annoy.
> > 10 sec or more is beginning to sound like it comes close to "too
> > long", and 20 sec is definitely too long.
> Thank you.  Now is clear.
> Are you OK with keep the sentence as it is now?
> I mean, keep: 'some few seconds'.

It's okay to leave it as is.  I also don't object to saying something
more specific, but 2-3 sec sound just too few to me.





  reply	other threads:[~2017-02-10  8:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-04 13:42 bug#25618: 25.1.91; More precise limit for tagging expensive tests Tino Calancha
2017-02-04 14:01 ` Noam Postavsky
2017-02-04 14:13   ` Tino Calancha
2017-02-04 16:50 ` Eli Zaretskii
2017-02-04 17:54   ` Tino Calancha
2017-02-10  8:49     ` Eli Zaretskii [this message]
2017-02-10  9:28       ` Tino Calancha
2017-02-05  9:53   ` Michael Albinus
2017-02-05 13:53     ` Noam Postavsky
2017-02-05 15:35 ` bug#25618: AW: " michael.albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83efz64ehp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=25618@debbugs.gnu.org \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).