From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25987: 25.2; support gcc fixit notes Date: Mon, 06 Mar 2017 20:35:55 +0200 Message-ID: <83efyai778.fsf@gnu.org> References: <87lgsj1jle.fsf@tromey.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1488825430 16242 195.159.176.226 (6 Mar 2017 18:37:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Mar 2017 18:37:10 +0000 (UTC) Cc: 25987@debbugs.gnu.org To: Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 06 19:37:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckxVJ-0003mz-Dn for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Mar 2017 19:37:05 +0100 Original-Received: from localhost ([::1]:45496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckxVP-0007n1-Fs for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Mar 2017 13:37:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36664) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckxVK-0007lr-49 for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2017 13:37:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckxVG-0003Pj-6N for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2017 13:37:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44910) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ckxVG-0003Pb-3h for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2017 13:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ckxVF-0006G3-Ru for bug-gnu-emacs@gnu.org; Mon, 06 Mar 2017 13:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Mar 2017 18:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25987 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25987-submit@debbugs.gnu.org id=B25987.148882537823999 (code B ref 25987); Mon, 06 Mar 2017 18:37:01 +0000 Original-Received: (at 25987) by debbugs.gnu.org; 6 Mar 2017 18:36:18 +0000 Original-Received: from localhost ([127.0.0.1]:43109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckxUY-0006F1-6H for submit@debbugs.gnu.org; Mon, 06 Mar 2017 13:36:18 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ckxUW-0006En-ET for 25987@debbugs.gnu.org; Mon, 06 Mar 2017 13:36:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ckxUN-00032a-C0 for 25987@debbugs.gnu.org; Mon, 06 Mar 2017 13:36:11 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ckxUN-00032W-83; Mon, 06 Mar 2017 13:36:07 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2297 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ckxUM-0004e0-H1; Mon, 06 Mar 2017 13:36:07 -0500 In-reply-to: <87lgsj1jle.fsf@tromey.com> (message from Tom Tromey on Sun, 05 Mar 2017 14:47:57 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130275 Archived-At: > From: Tom Tromey > Date: Sun, 05 Mar 2017 14:47:57 -0700 > > I think Emacs should support this in compilation mode buffers. I agree, it would be a good feature. > A few thoughts on the implementation: > > * The filename quoting stuff will require a bit of unquoting Perhaps shell-unquote-argument will help? > * The offsets are byte offsets, not columns, which is a bit of a pain > (or at least, it is for me since I don't know how to handle that in > elisp) Ouch! why did they do it in bytes? That's worth a bug report, IMO. Anyway, filepos-to-bufferpos could help with this problem. > * One way for this to work would be to display the buffer and > show the proposed change as an overlay; Or maybe a tooltip on GUI frames? > * However other approaches are possible, like letting the user request > no confirmation, or request "auto-apply all changes" or something. > Maybe a fixit should be associated with the previous error somehow. Is there perhaps some "prior art" for this in other IDEs out there? Thanks.