From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 24710@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#24710: 26.0.50; Feature request: Replace double quotes in electric-quote-mode
Date: Fri, 29 Sep 2017 10:08:42 +0300 [thread overview]
Message-ID: <83efqq9e2t.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkS2zb3ahK14BwoEwn6cNeqeZ7_mCfQq6RgLD=mgvoLuAg@mail.gmail.com> (message from Philipp Stephani on Sun, 24 Sep 2017 07:04:07 +0000)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Sun, 24 Sep 2017 07:04:07 +0000
> Cc: 24710@debbugs.gnu.org
>
> Eli Zaretskii wrote:
> > Thanks. How about updating the Emacs manual as well?
>
> Yes, other than that it looks good to me.
>
> OK, here's a new patch.
Thanks, this LGTM.
> Subject: [PATCH] Electric quote mode: Conditionally replace " (Bug#24710)
>
> * lisp/electric.el (electric-quote-replace-double): New user option.
> (electric-quote-post-self-insert-function): Use it.
>
> * electric-tests.el (electric-quote-replace-double-disabled)
> (electric-quote-replace-double-bob)
> (electric-quote-replace-double-bol)
> (electric-quote-replace-double-after-space)
> (electric-quote-replace-double-after-letter)
> (electric-quote-replace-double-after-paren): New unit tests.
Please add the log entries for the documentation here, when you push.
next prev parent reply other threads:[~2017-09-29 7:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 17:24 bug#24710: 26.0.50; Feature request: Replace double quotes in electric-quote-mode Philipp Stephani
2017-07-14 12:48 ` Paul Eggert
2017-07-23 20:01 ` Philipp Stephani
2017-07-24 7:55 ` Paul Eggert
2017-09-23 20:22 ` Philipp Stephani
2017-09-24 2:50 ` Eli Zaretskii
2017-09-24 5:03 ` Paul Eggert
2017-09-24 7:04 ` Philipp Stephani
2017-09-29 7:08 ` Eli Zaretskii [this message]
2017-09-30 22:21 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83efqq9e2t.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=24710@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).