bug#30039: 26.0.90; [26.1] Making my code warning free is impossible with when-let

[Eli Zaretskii <eliz@gnu.org>]

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Fri, 19 Jan 2018 15:40:22 -0500
> Cc: Damien Cassou <damien@cassou.me>, 30039@debbugs.gnu.org, 
> 	Nicolas Petton <nicolas@petton.fr>
> 
> On Fri, Jan 19, 2018 at 3:26 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> >> From: Noam Postavsky <npostavs@users.sourceforge.net>
> >> Date: Fri, 19 Jan 2018 15:00:30 -0500
> >> Cc: 30039@debbugs.gnu.org, Nicolas Petton <nicolas@petton.fr>
> >>
> >> Here's a finished version of the patch. Eli, is it okay for emacs-26?
> >
> > Why is this new feature is urgent or important enough to have it in
> > Emacs 26?
> 
> It's urgent, because it has to be in 26.1 in order to solve the
> problem in the OP.

But the problem in the OP is just a minor nuisance.

> More generally, if we introduce the feature in 26.1
> in can be useful for suppressing warnings from 26.1 and up, whereas if
> we delay it until 27, then it won't be helpful for things marked
> obsolete in 26.1. So the timing of when we add it directly affects the
> usefulness.
> 
> On the other hand, it's maybe not that important, as the problem is
> only a warning, and there are other ways of suppressing it (e.g., what
> I suggested in #11).

Exactly.  And since the 26.0.91 pretest is already tarred, and just
awaits to be uploaded, I'd prefer from now on to install on the
release branch only stuff that is really necessary (and documentation
patches).