From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33669: 26.1; Buffer-menu-mode bad UX Date: Sat, 12 Jan 2019 13:53:28 +0200 Message-ID: <83ef9if5xj.fsf@gnu.org> References: <037E6F90-F638-4DAC-8C9F-F2BE9F46569C@jovi.net> <83tvjo46pt.fsf@gnu.org> <83muoxal99.fsf@gnu.org> <83o98v1ojg.fsf@gnu.org> <0D3D3224-4085-4608-9367-02F51D74B528@jovi.net> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1547293930 25739 195.159.176.226 (12 Jan 2019 11:52:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2019 11:52:10 +0000 (UTC) Cc: 33669-done@debbugs.gnu.org To: Devon Sean McCullough Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 12 12:52:06 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHpe-0006Vl-0I for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 12:52:06 +0100 Original-Received: from localhost ([127.0.0.1]:57333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHrk-000376-Lx for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 06:54:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50354) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHrX-000365-FF for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:54:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giHrW-0004hd-Nt for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57310) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giHrW-0004hM-K2 for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1giHrW-0003z5-FD for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 06:54:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jan 2019 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33669 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 33669@debbugs.gnu.org, eliz@gnu.org, Emacs-Hacker2018@jovi.net Original-Received: via spool by 33669-done@debbugs.gnu.org id=D33669.154729403515297 (code D ref 33669); Sat, 12 Jan 2019 11:54:02 +0000 Original-Received: (at 33669-done) by debbugs.gnu.org; 12 Jan 2019 11:53:55 +0000 Original-Received: from localhost ([127.0.0.1]:56590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHrO-0003ye-RE for submit@debbugs.gnu.org; Sat, 12 Jan 2019 06:53:55 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giHrN-0003yQ-3u for 33669-done@debbugs.gnu.org; Sat, 12 Jan 2019 06:53:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giHrH-0004VZ-Lq; Sat, 12 Jan 2019 06:53:47 -0500 Original-Received: from [176.228.60.248] (port=2805 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1giHrH-0001Tv-9E; Sat, 12 Jan 2019 06:53:47 -0500 In-reply-to: <0D3D3224-4085-4608-9367-02F51D74B528@jovi.net> (message from Devon Sean McCullough on Sat, 5 Jan 2019 10:36:22 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154378 Archived-At: > From: Devon Sean McCullough > Date: Sat, 5 Jan 2019 10:36:22 -0500 > > > On Jan 5, 2019, at 3:44 AM, Eli Zaretskii wrote: > > Ping! Ping! Devon, could you please try the proposed fix? > > The original and patched versions both look problematic. Instead, I had good results with > > --- old/buff-menu.el 2019-01-05 10:26:45.000000000 -0500 > +++ new/buff-menu.el 2019-01-05 10:27:23.000000000 -0500 > @@ -475,10 +475,10 @@ > (save-buffer)) > (tabulated-list-set-col 2 " " t)) > (error (warn "Error saving %s" buffer)))) > - (if delete > - (unless (eq buffer (current-buffer)) > - (kill-buffer buffer) > - (tabulated-list-delete-entry)) > + (if (and delete > + (not (eq buffer (current-buffer))) > + (kill-buffer buffer)) > + (tabulated-list-delete-entry) > (forward-line 1))))))))) > > (defun Buffer-menu-select () > Thanks, pushed to the emacs-26 branch.