From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#9867: 24.0.90; quit-window should provide quit-window-hook Date: Tue, 20 Aug 2019 17:25:20 +0300 Message-ID: <83ef1flxrj.fsf@gnu.org> References: <861uu1ogxq.fsf@googlemail.com> <87d0h01sqf.fsf@mouse.gnus.org> <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102727"; mail-complaints-to="usenet@blaine.gmane.org" Cc: cschol2112@googlemail.com, larsi@gnus.org, 9867@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Aug 20 16:26:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i055O-000QaF-1G for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 16:26:10 +0200 Original-Received: from localhost ([::1]:37962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i055M-0000y4-9n for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Aug 2019 10:26:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53699) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i055G-0000xw-VI for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 10:26:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i055G-0008Nn-0d for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 10:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i055F-0008Nj-TS for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 10:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i055F-0006rS-Nl for bug-gnu-emacs@gnu.org; Tue, 20 Aug 2019 10:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Aug 2019 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9867 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 9867-submit@debbugs.gnu.org id=B9867.156631113426333 (code B ref 9867); Tue, 20 Aug 2019 14:26:01 +0000 Original-Received: (at 9867) by debbugs.gnu.org; 20 Aug 2019 14:25:34 +0000 Original-Received: from localhost ([127.0.0.1]:33521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i054n-0006qf-TC for submit@debbugs.gnu.org; Tue, 20 Aug 2019 10:25:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i054m-0006qR-C0 for 9867@debbugs.gnu.org; Tue, 20 Aug 2019 10:25:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i054d-0007xk-4m; Tue, 20 Aug 2019 10:25:25 -0400 Original-Received: from [176.228.60.248] (port=4690 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i054V-0005rJ-MS; Tue, 20 Aug 2019 10:25:17 -0400 In-reply-to: <761cfbbf-88ef-d161-fb7b-a906c12e5307@gmx.at> (message from martin rudalics on Tue, 20 Aug 2019 10:19:29 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165414 Archived-At: > From: martin rudalics > Date: Tue, 20 Aug 2019 10:19:29 +0200 > Cc: 9867@debbugs.gnu.org > > If people really need such a hook at all, please > > - Make it either an abnormal hook run with the window quit as argument > or run it from 'quit-window' but then only if it quits the selected > window. > > - Make sure to call any buffer-local value of that hook for the buffer > of the window that is quit. > > - Prefix it with 'quit-restore-' if you intend to run it from > 'quit-restore-window' (that function may be called by other > functions as well). > > - Fix the reference to the non-existent function 'quit-buffer'. And also: - Add the new hook to the list in the node "Standard Hooks" in the ELisp manual. Thanks.