From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37564: [PATCH] don't export LINES and COLUMNS env vars in term to fix ncurses applications Date: Tue, 01 Oct 2019 09:01:04 +0300 Message-ID: <83eezxatsv.fsf@gnu.org> References: <87y2y5lfnb.fsf@1e0.co.uk> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="9588"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37564@debbugs.gnu.org To: Matthew Leach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 08:02:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFBEm-0002Lx-3k for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 08:02:16 +0200 Original-Received: from localhost ([::1]:59174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFBEj-0006uz-EL for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 02:02:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42337) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFBEa-0006uX-0G for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 02:02:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFBEY-0000kI-AV for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 02:02:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51968) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFBEY-0000jv-2Y for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 02:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFBEX-000389-RD for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 02:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 06:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37564 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37564-submit@debbugs.gnu.org id=B37564.156990967511973 (code B ref 37564); Tue, 01 Oct 2019 06:02:01 +0000 Original-Received: (at 37564) by debbugs.gnu.org; 1 Oct 2019 06:01:15 +0000 Original-Received: from localhost ([127.0.0.1]:60789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFBDm-000372-Mp for submit@debbugs.gnu.org; Tue, 01 Oct 2019 02:01:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFBDk-00036q-U3 for 37564@debbugs.gnu.org; Tue, 01 Oct 2019 02:01:13 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFBDf-0000RR-GQ; Tue, 01 Oct 2019 02:01:07 -0400 Original-Received: from [176.228.60.248] (port=3778 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFBDe-0003BH-4a; Tue, 01 Oct 2019 02:01:07 -0400 In-reply-to: <87y2y5lfnb.fsf@1e0.co.uk> (message from Matthew Leach on Mon, 30 Sep 2019 20:59:04 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167971 Archived-At: > From: Matthew Leach > Date: Mon, 30 Sep 2019 20:59:04 +0100 > > The attached patch removes the exporting of the LINES and COLUMNS > environment variables in term-mode. Exporting these variables causes > issues for ncurses applications. For example, when running: > > emacs -Q > M-x term > (to select /bin/bash) > htop (to run htop) > > and resizing the window (especially making it smaller) can make the > program impossible to read. Thanks, but I don't think we can make this change unconditionally, because not all applications that heed LINES and COLUMNS use ncurses. I wonder if we can do better than just providing a defcustom.