From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39373: 27.0.50; [PATCH] mode-local-print-bindings broken with lexical-binding Date: Sat, 01 Feb 2020 09:48:19 +0200 Message-ID: <83eevekat8.fsf@gnu.org> References: <495920D0-A298-43BF-99E6-B5ADA06113CB@acm.org> <83lfpnjuiz.fsf@gnu.org> <928DB820-6899-4653-8872-82CE3CF567CD@acm.org> <83imkrjrvh.fsf@gnu.org> <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="99037"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39373@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 01 08:49:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ixnWn-000PeK-I8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Feb 2020 08:49:17 +0100 Original-Received: from localhost ([::1]:36646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixnWm-0007pT-Je for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 01 Feb 2020 02:49:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34898) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ixnWZ-0007pK-GV for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 02:49:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ixnWY-0000mG-Gk for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 02:49:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60572) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ixnWY-0000lK-9W for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 02:49:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ixnWY-00041X-6M for bug-gnu-emacs@gnu.org; Sat, 01 Feb 2020 02:49:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Feb 2020 07:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39373-submit@debbugs.gnu.org id=B39373.158054332515444 (code B ref 39373); Sat, 01 Feb 2020 07:49:02 +0000 Original-Received: (at 39373) by debbugs.gnu.org; 1 Feb 2020 07:48:45 +0000 Original-Received: from localhost ([127.0.0.1]:38312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixnWG-000412-W6 for submit@debbugs.gnu.org; Sat, 01 Feb 2020 02:48:45 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ixnWF-00040q-0X for 39373@debbugs.gnu.org; Sat, 01 Feb 2020 02:48:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34685) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ixnW9-00006H-Ni; Sat, 01 Feb 2020 02:48:37 -0500 Original-Received: from [176.228.60.248] (port=1826 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ixnW9-0002FN-5z; Sat, 01 Feb 2020 02:48:37 -0500 In-reply-to: <8EF7D3C6-041D-493F-859B-55D8D35AF588@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Fri, 31 Jan 2020 21:51:48 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175546 Archived-At: > From: Mattias Engdegård > Date: Fri, 31 Jan 2020 21:51:48 +0100 > Cc: 39373@debbugs.gnu.org > > 'add-to-list' doesn't work on lexical variables because it's a plain > function taking the variable symbol as argument. 'push' works on > lexical variables since it is a macro that expands to direct > variable reference and setq. If that's the case, then why don't we say that loud and clear in the ELisp manual? (The doc string of add-to-list has some vague recommendation, not sure if it really talks about this aspect, but that's definitely not enough for such a serious issue.) And doesn't it mean we should audit all the gazillion uses of add-to-list in our sources, and do that urgently? > I should perhaps have included this in the commit message. That would have definitely helped, thanks. > We could sink the pushes to the leaves of the condition tree, if you prefer: No, your original patch is fine, but please let's update the docs ASAP. Thanks.