unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Raphael 'kena' Poss <knz@thaumogen.net>
Cc: 39390@debbugs.gnu.org
Subject: bug#39390: 28.0.50; prettify-symbols-mode confuses display when start/end faces are different
Date: Sun, 02 Feb 2020 19:18:52 +0200	[thread overview]
Message-ID: <83eevcj4ar.fsf@gnu.org> (raw)
In-Reply-To: <3184164c-5d94-6cb3-aca4-338b710bf97f@thaumogen.net> (message from Raphael 'kena' Poss on Sun, 2 Feb 2020 15:45:46 +0100)

> From: Raphael 'kena' Poss <knz@thaumogen.net>
> Date: Sun, 2 Feb 2020 15:45:46 +0100
> 
> (add-hook 'go-mode-hook
>  (lambda ()
>    (push '("error" . ?⊙) prettify-symbols-alist)
>    ;; (push '("err != nil" . "⊙?") prettify-symbols-alist)
>  ))
> 
> However if I then uncomment the second substitution for "err != nil":
> all hell breaks loose: moving the cursor up and down around a source
> line containing this text will mess up the display of the lines that
> follow in a way that is sometimes irrecoverable.
> 
> The display bug is exacerbated (and thus easier to recognize/reproduce)
> when global-hl-line-mode is set.
> 
> I have traced this down to substitutions where the font-lock face at the
> beginning and the end of the symbol composition is different:
> 
> - replacing "String" is OK, replacing ".String()" is not
> - replacing "func" is OK, replacing "func(" is not
> - replacing "Fatal" is OK, replacing "t.Fatal" is not
> 
> This probably needs to be fixed somehow, either by preventing the
> problem or by documenting the pitfall.
> 
> I would like to know if a workaround is available?

You've bumped into a fundamental limitation of the feature, called
"character composition", that prettify-symbols-mode piggy-backs to do
its thing: Emacs can only compose characters that all have the same
face.  This restriction is imposed on a very low level of the display
code.

So I don't think there can be a workaround, except by "fixing" the
font-lock faces to use the same face on all the characters you want to
substitute.





  reply	other threads:[~2020-02-02 17:18 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 14:45 bug#39390: 28.0.50; prettify-symbols-mode confuses display when start/end faces are different Raphael 'kena' Poss
2020-02-02 17:18 ` Eli Zaretskii [this message]
2020-02-02 17:56   ` Raphael 'kena' Poss
2020-02-02 18:03     ` Eli Zaretskii
2020-02-02 18:28       ` Raphael 'kena' Poss
2020-02-02 19:20         ` Eli Zaretskii
2020-02-02 20:00           ` Raphael 'kena' Poss
2020-02-02 20:09             ` Eli Zaretskii
2020-02-02 20:26               ` Raphael 'kena' Poss
2020-02-03 15:50                 ` Eli Zaretskii
2020-02-04 22:07                   ` Raphael 'kena' Poss
2020-02-16 17:46                     ` Eli Zaretskii
2020-02-16 18:37                       ` Raphael 'kena' Poss
2020-02-16 19:29                         ` Eli Zaretskii
2020-02-16 19:34                           ` Eli Zaretskii
2020-02-16 19:40                             ` Raphael 'kena' Poss
2020-02-16 20:23                               ` Eli Zaretskii
2020-02-17  2:47                                 ` Raphael 'kena' Poss
2020-02-17 11:17                                   ` Tassilo Horn
2020-02-17 12:35                                     ` Raphael 'kena' Poss
2020-02-17 15:59                                       ` Tassilo Horn
2020-02-17 16:06                                         ` Raphael 'kena' Poss
2020-02-17 17:30                                         ` Eli Zaretskii
2020-02-17 18:37                                           ` Raphael 'kena' Poss
2020-02-17 19:24                                             ` Eli Zaretskii
2020-02-17 19:28                                               ` Raphael 'kena' Poss
2020-02-17 20:14                                                 ` Eli Zaretskii
2020-02-17 17:11                                     ` Eli Zaretskii
2020-02-17 17:13                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83eevcj4ar.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39390@debbugs.gnu.org \
    --cc=knz@thaumogen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).