From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37215: [PATCH] vc-cvs-ignore writes absolute filenames and duplicate strings Date: Fri, 21 Feb 2020 11:31:03 +0200 Message-ID: <83eeuojnhk.fsf@gnu.org> References: <87imptwvoa.fsf@gnus.org> <87k15jy84c.fsf@gnus.org> <543853fe-6cc2-9d1e-093e-e90e0886eed2@gmx.de> <831rqyqnya.fsf@gnu.org> <83pnehpnyr.fsf@gnu.org> <31d20c7f-aec2-8b93-0643-f0fa611eb816@gmx.de> <83imk8nvl4.fsf@gnu.org> <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="20494"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 37215@debbugs.gnu.org, larsi@gnus.org, dgutov@yandex.ru To: Wolfgang Scherer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 21 10:32:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j54fO-0005Cz-5j for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 10:32:14 +0100 Original-Received: from localhost ([::1]:54424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j54fN-0007TS-7M for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Feb 2020 04:32:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51561) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j54fD-0007Sz-FE for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 04:32:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j54fC-0008Cv-BL for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 04:32:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j54fC-0008Cf-72 for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 04:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j54fC-0004vH-3R for bug-gnu-emacs@gnu.org; Fri, 21 Feb 2020 04:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2020 09:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37215 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37215-submit@debbugs.gnu.org id=B37215.158227748318877 (code B ref 37215); Fri, 21 Feb 2020 09:32:02 +0000 Original-Received: (at 37215) by debbugs.gnu.org; 21 Feb 2020 09:31:23 +0000 Original-Received: from localhost ([127.0.0.1]:46405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j54eZ-0004uP-DT for submit@debbugs.gnu.org; Fri, 21 Feb 2020 04:31:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j54eX-0004u9-JB for 37215@debbugs.gnu.org; Fri, 21 Feb 2020 04:31:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j54eR-0006YC-Sw; Fri, 21 Feb 2020 04:31:15 -0500 Original-Received: from [176.228.60.248] (port=2743 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j54eQ-0005Tv-NG; Fri, 21 Feb 2020 04:31:15 -0500 In-reply-to: <6aaa5f28-13da-e998-a2b5-3a52a97b9dde@gmx.de> (message from Wolfgang Scherer on Thu, 20 Feb 2020 00:06:11 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176355 Archived-At: > Cc: larsi@gnus.org, 37215@debbugs.gnu.org, dgutov@yandex.ru > From: Wolfgang Scherer > Date: Thu, 20 Feb 2020 00:06:11 +0100 > > > I'd like to install your patch, and I'd like to do it soon, so it > > makes it into Emacs 27. Can you please propose a modified patch which > > adds some minimal information about what's going on to the doc string > > and/or the comments around the code? > > Here is the revised patch. I have cleared the FIXME issue mentioned by Lars and added commentary to what is going on. Thanks, this LGTM. Just a couple of minor nits, and we can install this. > (lisp/vc/pcvs.el) Call ‘vc-cvs-append-to-ignore’ with SORT argument. Please quote 'like this' in log messages, and try to avoid non-ASCII characters there (they are generally only necessary in people's names). > +Patterns follow glob(7) syntax. Special characters \"?*[\\\" are > +escaped with a backslash." I'd say "should be escaped" here, since this is a requirement for the argument passed to this function. Also, I'd mention that FILE can be a pattern, otherwise the reference to patterns might come as a surprise to the reader. > +to hear about anymore. If SORT is non-nil, sort the ines of the > +ignore file." ^^^^ Typo: should be "lines". > + (goto-char (point-min)) > + (save-match-data > + (unless (re-search-forward (concat "^" (regexp-quote str) "$") nil t) > + (goto-char (point-max)) You could use non-nil, non-t 3rd argument of re-search-forward, in which case the following goto-char would be redundant, right?