From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode Date: Sun, 06 Dec 2020 21:56:51 +0200 Message-ID: <83eek2aet8.fsf@gnu.org> References: <87y52arljh.fsf@yandex.ru> <87lfebassa.fsf@gnus.org> <87k0tvt04n.fsf@gmail.com> <83r1o39bab.fsf@gnu.org> <157e9a89-6d6c-1d3e-9308-e81d7442889a@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36456"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 16514@debbugs.gnu.org, kevin.legouguec@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 06 20:58:51 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1km0BH-0009MO-Jj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 20:58:51 +0100 Original-Received: from localhost ([::1]:48490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km0BG-0006BW-LU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 06 Dec 2020 14:58:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54044) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1km0AU-0005df-JN for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39860) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1km0AU-0005WG-4k for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1km0AU-0005N5-4I for bug-gnu-emacs@gnu.org; Sun, 06 Dec 2020 14:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 06 Dec 2020 19:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16514 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 16514-submit@debbugs.gnu.org id=B16514.160728463820593 (code B ref 16514); Sun, 06 Dec 2020 19:58:02 +0000 Original-Received: (at 16514) by debbugs.gnu.org; 6 Dec 2020 19:57:18 +0000 Original-Received: from localhost ([127.0.0.1]:51406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km09m-0005M5-GL for submit@debbugs.gnu.org; Sun, 06 Dec 2020 14:57:18 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km09l-0005Lt-83 for 16514@debbugs.gnu.org; Sun, 06 Dec 2020 14:57:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41615) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km09f-0005Eh-7D; Sun, 06 Dec 2020 14:57:11 -0500 Original-Received: from [176.228.60.248] (port=4621 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1km09X-0005VQ-1P; Sun, 06 Dec 2020 14:57:04 -0500 In-Reply-To: <157e9a89-6d6c-1d3e-9308-e81d7442889a@yandex.ru> (message from Dmitry Gutov on Sun, 6 Dec 2020 21:34:44 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:195170 Archived-At: > Cc: larsi@gnus.org, 16514@debbugs.gnu.org > From: Dmitry Gutov > Date: Sun, 6 Dec 2020 21:34:44 +0200 > > > This is expected, since we sort overlays so that the one whose extent > > is larger wins. > > > > To do anything else the overlays should have priorities. > > So it's probably correct from the low-level primitives POV. > > But is this a good UI? And shouldn't we maybe tweak the high-level > implementation (perhaps, the way how the refinements are applied) so > that the behavior is better? I agree that the end result is not the best one. If by "tweak the high-level implementation" you meant something like use priorities for the relevant overlays, then that's exactly what I tried to hint at. IOW, yes, we should do something on the application level to cause the selected region look consistently.