From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Tue, 02 Mar 2021 07:51:31 +0200 Message-ID: <83eegy6r30.fsf@gnu.org> References: <87im9fgm27.fsf@protesilaos.com> <83mtyk1hq3.fsf@gnu.org> <87czzgbapt.fsf@protesilaos.com> <83lfe4192f.fsf@gnu.org> <83im9814oh.fsf@gnu.org> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> <87h7luga3p.fsf@protesilaos.com> <87o8g2bg89.fsf@tcd.ie> <87r1kyrtrl.fsf@protesilaos.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5191"; mail-complaints-to="usenet@ciao.gmane.io" Cc: contovob@tcd.ie, 45068@debbugs.gnu.org, maurooaranda@gmail.com To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 02 06:52:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGxx3-0001Az-UH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 06:52:09 +0100 Original-Received: from localhost ([::1]:45186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGxx2-0002PA-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Mar 2021 00:52:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGxwv-0002P0-PX for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 00:52:01 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGxwv-00085r-IG for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 00:52:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGxwv-00053o-Gs for bug-gnu-emacs@gnu.org; Tue, 02 Mar 2021 00:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Mar 2021 05:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161466430219426 (code B ref 45068); Tue, 02 Mar 2021 05:52:01 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 2 Mar 2021 05:51:42 +0000 Original-Received: from localhost ([127.0.0.1]:51415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGxwa-00053F-Uk for submit@debbugs.gnu.org; Tue, 02 Mar 2021 00:51:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGxwa-000533-3N for 45068@debbugs.gnu.org; Tue, 02 Mar 2021 00:51:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33424) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGxwT-0007nn-Oq; Tue, 02 Mar 2021 00:51:33 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1835 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lGxwT-0002J4-4f; Tue, 02 Mar 2021 00:51:33 -0500 In-Reply-To: <87r1kyrtrl.fsf@protesilaos.com> (message from Protesilaos Stavrou on Tue, 02 Mar 2021 07:47:58 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201185 Archived-At: > From: Protesilaos Stavrou > Cc: Mauro Aranda , Eli Zaretskii , > 45068@debbugs.gnu.org > Date: Tue, 02 Mar 2021 07:47:58 +0200 > > > (defun require-theme (feature &optional noerror) > > (let ((load-path (custom-theme--load-path))) > > (require feature nil noerror))) > > No the themes do not need that dual behaviour. And yes, your version > works and I am happy with it: all I need is a 'require' that reads from > etc/themes. Won't the above version cause problems if the loaded theme needs to require some Emacs package? Binding load-path would get in the way of that, no?