From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Date: Wed, 28 Apr 2021 14:47:40 +0300 Message-ID: <83eeeuhbqb.fsf@gnu.org> References: <20210427190243.n5yg3gywd5wma3jl@E15-2016.optimum.net> <83lf93h6x1.fsf@gnu.org> <20210427193253.ourhlr3nxdem3e6t@E15-2016.optimum.net> <83k0ongnc7.fsf@gnu.org> <20210428030025.75hiu5zgrll2qzeq@E15-2016.optimum.net> <87fszbnd70.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21397"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48072@debbugs.gnu.org, boruch_baum@gmx.com To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 28 13:48:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbifq-0005TM-AF for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 13:48:10 +0200 Original-Received: from localhost ([::1]:59676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbifp-0001DS-AL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Apr 2021 07:48:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbifi-0001DA-Kd for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 07:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbifi-0006Th-Cf for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 07:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbifi-0005QZ-AX for bug-gnu-emacs@gnu.org; Wed, 28 Apr 2021 07:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Apr 2021 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48072 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48072-submit@debbugs.gnu.org id=B48072.161961048120857 (code B ref 48072); Wed, 28 Apr 2021 11:48:02 +0000 Original-Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 11:48:01 +0000 Original-Received: from localhost ([127.0.0.1]:51912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbifh-0005QK-H2 for submit@debbugs.gnu.org; Wed, 28 Apr 2021 07:48:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbife-0005Q4-Vg for 48072@debbugs.gnu.org; Wed, 28 Apr 2021 07:48:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbifZ-0006Ni-La; Wed, 28 Apr 2021 07:47:53 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4700 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lbifZ-0007If-1J; Wed, 28 Apr 2021 07:47:53 -0400 In-Reply-To: <87fszbnd70.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Wed, 28 Apr 2021 08:19:31 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205097 Archived-At: > From: Kévin Le Gouguec > Cc: Eli Zaretskii , 48072@debbugs.gnu.org > Date: Wed, 28 Apr 2021 08:19:31 +0200 > > Boruch Baum writes: > > >> > > This is certainly a mistake: a valid shell command doesn't have to be > >> > > a file that executable-find is able to find. Shells are known to > >> > > support all kinds of internal and magic commands. > >> > > >> > My testing indicates otherwise. > >> > >> Would you care to share the details of that testing, please? > > > > I evaluated shell-command-to-string for shell aliases and shell > > functions, all of which returned error of type 'command not found'. That > > would indicate that the class of 'internal commands' aren't valid in the > > current state of emacs. > > Shell builtins seem to work though: Yes, I meant builtins when I said "internal commands". Sorry for my sloppy wording.