From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#12972: [PATCH] Avoid regression in mailcap-view-file similar to Bug#44824 Date: Mon, 05 Jul 2021 18:23:54 +0300 Message-ID: <83eecchjhx.fsf@gnu.org> References: <87r1hmdqek.fsf__16088.3597027109$1622530682$gmane$org@gnus.org> <835yxtlw14.fsf__2546.8955327355$1625164803$gmane$org@gnu.org> <1ddf1c46-0a28-4a2d-cc40-094ff74ee0ac@gmail.com> <837di8ki24.fsf__46278.4886871063$1625229533$gmane$org@gnu.org> <831r8gk4m0.fsf__14172.0669272885$1625246977$gmane$org@gnu.org> <1825a6f3-0175-2d67-5608-41c9fb93889b@gmail.com> <83im1ripaz.fsf__31901.4239286602$1625313464$gmane$org@gnu.org> <83zgv2gpdq.fsf@gnu.org> <16b88d78-de85-75d8-4e37-fd56eef87522@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38167"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 12972@debbugs.gnu.org To: Maxim Nikulin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 05 17:24:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m0QSA-0009lW-OU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jul 2021 17:24:10 +0200 Original-Received: from localhost ([::1]:41070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0QS9-0008Cb-Hi for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Jul 2021 11:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0QS2-0008CP-Ln; Mon, 05 Jul 2021 11:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34921) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m0QS2-0005fz-ES; Mon, 05 Jul 2021 11:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m0QS2-00043D-Bt; Mon, 05 Jul 2021 11:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Mon, 05 Jul 2021 15:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12972 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: patch Original-Received: via spool by 12972-submit@debbugs.gnu.org id=B12972.162549863715559 (code B ref 12972); Mon, 05 Jul 2021 15:24:02 +0000 Original-Received: (at 12972) by debbugs.gnu.org; 5 Jul 2021 15:23:57 +0000 Original-Received: from localhost ([127.0.0.1]:46467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QRw-00042t-N7 for submit@debbugs.gnu.org; Mon, 05 Jul 2021 11:23:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m0QRu-00042d-VT for 12972@debbugs.gnu.org; Mon, 05 Jul 2021 11:23:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40806) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m0QRp-0005Wk-MY; Mon, 05 Jul 2021 11:23:49 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1799 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m0QRp-0003A2-9G; Mon, 05 Jul 2021 11:23:49 -0400 In-Reply-To: <16b88d78-de85-75d8-4e37-fd56eef87522@gmail.com> (message from Maxim Nikulin on Mon, 5 Jul 2021 20:12:34 +0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209470 Archived-At: > From: Maxim Nikulin > Date: Mon, 5 Jul 2021 20:12:34 +0700 > > It is about proper way to a launch viewer in > `mailcap-view-file'. Original `start-process-shell-command' with 'pty > connection type prematurely kills children of kde-open5 or gio open. > With 'pipe connection type it or `make-process' might make emacs CPU > hungry if a child decides to close stdout and stderr: > > >> #!/bin/sh > >> exec 1>&- > >> exec 2>&- > >> sleep 30 Is the above something a file viewer is likely to do? And if it does, how would you suggest to countermand that? > and finally `process-file-shell-command' does not allow to report > failure. The original code uses start-process-shell-command, and I don't think I understand why you wanted to call process-file-shell-command instead. Can you explain?