From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49449: 28: TLS connection never gets to "open" stage Date: Sun, 11 Jul 2021 13:14:16 +0300 Message-ID: <83eec5b1jb.fsf@gnu.org> References: <87lf6h3nj0.fsf@gnus.org> <22155A42-4A01-4EF1-80BC-B9CDE31ED0B1@acm.org> <87o8bdt180.fsf@gnus.org> <875yxip21h.fsf@gnus.org> <875yxinm2e.fsf@gnus.org> <83sg0matjg.fsf@gnu.org> <6FC06816-48AF-4853-92A9-B0E6BA424533@acm.org> <83pmvqarua.fsf@gnu.org> <580679E8-B94D-4B46-A0CB-CA52B9D535EB@acm.org> <83fswlbb1c.fsf@gnu.org> <23DD5CB6-5035-4C19-91B8-548F0B47E9FC@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22285"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49449@debbugs.gnu.org, larsi@gnus.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 11 12:15:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2WUP-0005cI-Kj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Jul 2021 12:15:09 +0200 Original-Received: from localhost ([::1]:44852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2WUO-0004SZ-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Jul 2021 06:15:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2WUI-0004SO-7Y for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 06:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m2WUH-0005LL-SA for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 06:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m2WUH-0002RV-La for bug-gnu-emacs@gnu.org; Sun, 11 Jul 2021 06:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Jul 2021 10:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49449 X-GNU-PR-Package: emacs Original-Received: via spool by 49449-submit@debbugs.gnu.org id=B49449.16259984749339 (code B ref 49449); Sun, 11 Jul 2021 10:15:01 +0000 Original-Received: (at 49449) by debbugs.gnu.org; 11 Jul 2021 10:14:34 +0000 Original-Received: from localhost ([127.0.0.1]:33953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2WTq-0002QZ-Cl for submit@debbugs.gnu.org; Sun, 11 Jul 2021 06:14:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m2WTp-0002QM-5a for 49449@debbugs.gnu.org; Sun, 11 Jul 2021 06:14:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41340) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2WTj-0004sl-N1; Sun, 11 Jul 2021 06:14:27 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1342 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2WTj-0004hz-AL; Sun, 11 Jul 2021 06:14:27 -0400 In-Reply-To: <23DD5CB6-5035-4C19-91B8-548F0B47E9FC@acm.org> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Sun, 11 Jul 2021 09:42:34 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:209789 Archived-At: > Feedback-ID:mattiase@acm.or > From: Mattias Engdegård > Date: Sun, 11 Jul 2021 09:42:34 +0200 > Cc: larsi@gnus.org, 49449@debbugs.gnu.org > > 11 juli 2021 kl. 08.49 skrev Eli Zaretskii : > > > why not reset the > > NON_BLOCKING_CONNECT_FD bit before we call finish_after_tls_connection > > from that place? > > That's tantamount to jamming a metal screwdriver into the condition on line 3277, which was indeed the first thing I tried. Unfortunately it doesn't work -- after the sentinel is called, no further progress is made, probably because we (by lying) haven't set up the connection properly. Did you succeed in understanding what else has to happen before that flag could be safely reset? And anyway, if those conditions are not yet set, I wonder why are we calling finish_after_tls_connection at that place?