From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#21695: 25.0.50; Change most occurrences of `setq' in Emacs manual to `customize-set-variable'? Really? Date: Sun, 12 Sep 2021 12:37:49 +0300 Message-ID: <83ee9uf82a.fsf@gnu.org> References: <97d3ff2c-9e72-4004-88a9-08130ac99a74@default> <838s0fpixr.fsf@gnu.org> <83k0jtr45c.fsf@gnu.org> <87v93avtoe.fsf@gnus.org> <87r1dyvtav.fsf@gnus.org> <87mtolx6de.fsf@gnus.org> <87ilz9x5c8.fsf@gnus.org> <87y284rb1z.fsf@gnus.org> <0d48a23084a8b0435f37@heytings.org> <83h7eqf9wx.fsf@gnu.org> <0d48a230848de1d1b255@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17340"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, hmelman@gmail.com, 21695@debbugs.gnu.org, rms@gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 12 11:39:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPLxF-0004K2-SH for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Sep 2021 11:39:17 +0200 Original-Received: from localhost ([::1]:49506 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPLxD-00005g-Aj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Sep 2021 05:39:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPLx0-0008Tk-Cg for bug-gnu-emacs@gnu.org; Sun, 12 Sep 2021 05:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPLx0-0001qk-4Z for bug-gnu-emacs@gnu.org; Sun, 12 Sep 2021 05:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPLx0-0007D0-2V for bug-gnu-emacs@gnu.org; Sun, 12 Sep 2021 05:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Sep 2021 09:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21695 X-GNU-PR-Package: emacs Original-Received: via spool by 21695-submit@debbugs.gnu.org id=B21695.163143949727617 (code B ref 21695); Sun, 12 Sep 2021 09:39:02 +0000 Original-Received: (at 21695) by debbugs.gnu.org; 12 Sep 2021 09:38:17 +0000 Original-Received: from localhost ([127.0.0.1]:42095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPLwH-0007BN-0U for submit@debbugs.gnu.org; Sun, 12 Sep 2021 05:38:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPLwE-0007BA-Te for 21695@debbugs.gnu.org; Sun, 12 Sep 2021 05:38:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:54730) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPLw8-00012X-7v; Sun, 12 Sep 2021 05:38:08 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2084 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPLw1-0008Sm-W5; Sun, 12 Sep 2021 05:38:02 -0400 In-Reply-To: <0d48a230848de1d1b255@heytings.org> (message from Gregory Heytings on Sun, 12 Sep 2021 09:30:21 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214126 Archived-At: > Date: Sun, 12 Sep 2021 09:30:21 +0000 > From: Gregory Heytings > cc: larsi@gnus.org, 21695@debbugs.gnu.org, hmelman@gmail.com, rms@gnu.org > > > What will happen if setq is in the user's init file? We generally delay > > warnings until after the startup in those cases. > > > > With the following .emacs: > > (require 'allout) > (setq allout-auto-activation t) > > a warning is displayed, but I don't know if this is during of after the > startup. At least it is visible when startup has completed. You need a much larger init file with several setq like this. The warnings usually fly by you without giving enough chance to read them. > > Also, warnings.el is not preloaded, so this call could barf in some > > valid cases. > > > > That's not what I see: > > ;;;###autoload > (defun display-warning (type message &optional level buffer-name) That's autoloaded, not preloaded; the latter is in loadup.el. > > And finally, do we really want to slow down each setq by calling intern > > and Fget? setq is many times used inside tight loops. I'm not sure the > > resulting run-time penalty is justified. Did you measure the effect of > > this on performance? > > > > With the updated patch, on my laptop, the execution of setq takes ~48 > nanoseconds instead of ~40 nanoseconds. Which seems reasonable. Is this multiplicative, i.e. if you perform it many times, does it indeed take 20% longer overall? If so, this is not an acceptable performance hit, I think, not for such a minor feature.