From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 02 Nov 2021 19:13:06 +0200 Message-ID: <83ee7yjxb1.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4377"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 18:16:59 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhxP9-0000sK-8r for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 18:16:59 +0100 Original-Received: from localhost ([::1]:58114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhxP7-0001IW-2u for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 13:16:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48172) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhxMJ-00075s-3g for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 13:14:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhxMI-0002dl-GB for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 13:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhxMI-0005ME-9g for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 13:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 17:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163587320120507 (code B ref 51556); Tue, 02 Nov 2021 17:14:02 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 17:13:21 +0000 Original-Received: from localhost ([127.0.0.1]:37944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxLd-0005Kh-5k for submit@debbugs.gnu.org; Tue, 02 Nov 2021 13:13:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhxLZ-0005KJ-HB for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 13:13:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48532) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhxLT-0002Wn-Ot; Tue, 02 Nov 2021 13:13:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G/nEJPzQUzM52HIMtTVuCeqSlCItpvaHsrv4xy4eow8=; b=DLAEDuLcIpUR 0CTgHtnxbZ3vImR5ANyRyn0Xs8eZC7zXvIXlRUYmHe4LmCcaI8xnNYRAwBfYAjX/C8jzo/toU4Miy 9vYz1oonFfrFD702hCIwBETJ0l6QxVVUXqfZAzG6sPHYcqK/vGGweTVBCMWruuQaSFzLDGq5/40nT w3WSz8LJhILeMCPH2lETXIG/DRHCbHL3jYGJxUiDZL9ovSfxta1m8M3saaZCUHbolPHkgCXPZRUKI XBvRfPm256PGDrrTW2RtpIsp9W+UZUa+SAfvUPJLjUUR9s9W5pZZrvxhJiv/DH2IL6rbD03UEZPfR tcQ0Dh36wR0J41u2qqiiRw==; Original-Received: from [87.69.77.57] (port=1420 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhxLS-0004si-Ms; Tue, 02 Nov 2021 13:13:11 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 10:01:56 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218820 Archived-At: > From: Stefan Kangas > Date: Tue, 2 Nov 2021 10:01:56 -0700 > Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > Eli Zaretskii writes: > > > I don't think I understand what that means. We disregard the colors > > specified by the SVG image? > > No, we do respect colors specified by the SVG image. That's why we see > the current behavior. > > However, if no foreground color is specified in the SVG file, we use the > foreground color of the current face instead. That's why the fix I > propose work. What is the difference between "colors specified by the SVG image" (which you say we respect), and "foreground color is specified in the SVG file" (which you want us to disregard)? > > Sorry, at this stage I'd prefer not to install anything on the release > > branch that isn't a bugfix. Or else take it up with Lars, and ask him > > to forget about releasing Emacs 28.1 soon, because this way it will > > take a while ;-) > > I consider this a bug fix, but admittedly only a minor one. However, I > also note that the visibility of those symbols is worse with a dark > theme in Emacs 28 than in Emacs 27, so we might consider it a > regression. Let's not exaggerate, okay?