From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com
Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds
Date: Tue, 02 Nov 2021 19:13:06 +0200 [thread overview]
Message-ID: <83ee7yjxb1.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmnFYw7R3stgFunbAK_A4Tbox-AAmtQRy0ZQ_XjmZVO2Vw@mail.gmail.com> (message from Stefan Kangas on Tue, 2 Nov 2021 10:01:56 -0700)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 2 Nov 2021 10:01:56 -0700
> Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > I don't think I understand what that means. We disregard the colors
> > specified by the SVG image?
>
> No, we do respect colors specified by the SVG image. That's why we see
> the current behavior.
>
> However, if no foreground color is specified in the SVG file, we use the
> foreground color of the current face instead. That's why the fix I
> propose work.
What is the difference between "colors specified by the SVG image"
(which you say we respect), and "foreground color is specified in the
SVG file" (which you want us to disregard)?
> > Sorry, at this stage I'd prefer not to install anything on the release
> > branch that isn't a bugfix. Or else take it up with Lars, and ask him
> > to forget about releasing Emacs 28.1 soon, because this way it will
> > take a while ;-)
>
> I consider this a bug fix, but admittedly only a minor one. However, I
> also note that the visibility of those symbols is worse with a dark
> theme in Emacs 28 than in Emacs 27, so we might consider it a
> regression.
Let's not exaggerate, okay?
next prev parent reply other threads:[~2021-11-02 17:13 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 17:56 bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Kévin Le Gouguec
2021-11-01 19:14 ` Eli Zaretskii
2021-11-01 20:10 ` Kévin Le Gouguec
2021-11-02 12:40 ` Eli Zaretskii
2021-11-01 20:49 ` Jim Porter
2021-11-02 12:49 ` Eli Zaretskii
2021-11-02 14:41 ` Stefan Kangas
2021-11-02 14:59 ` Eli Zaretskii
2021-11-02 15:17 ` Stefan Kangas
2021-11-02 15:26 ` Stefan Kangas
2021-11-02 16:38 ` Eli Zaretskii
2021-11-02 16:43 ` Lars Ingebrigtsen
2021-11-02 17:01 ` Stefan Kangas
2021-11-02 17:13 ` Eli Zaretskii [this message]
2021-11-02 17:44 ` Stefan Kangas
2021-11-02 18:01 ` Eli Zaretskii
2021-11-02 18:43 ` Stefan Kangas
2021-11-02 18:53 ` Eli Zaretskii
2021-11-02 19:26 ` Stefan Kangas
2021-11-02 18:43 ` Jim Porter
2021-11-02 18:58 ` Stefan Kangas
2021-11-02 19:15 ` Eli Zaretskii
2021-11-02 19:44 ` Stefan Kangas
2021-11-02 20:19 ` Alan Third
2021-11-02 22:56 ` Kévin Le Gouguec
2021-11-04 8:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ee7yjxb1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51556@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=kevin.legouguec@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).