From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#47291: bug#51404: Support system dark mode on Windows 10 Date: Thu, 11 Nov 2021 17:08:04 +0200 Message-ID: <83ee7m20iz.fsf@gnu.org> References: <834k93zxyo.fsf@gnu.org> <838ryfyawv.fsf@gnu.org> <83r1c5tyar.fsf@gnu.org> <83a6iqpzrv.fsf@gnu.org> <83k0huo1iy.fsf@gnu.org> <87wnlf8d9y.fsf@gnus.org> <83wnlf166j.fsf@gnu.org> <87wnle6g8o.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34188"; mail-complaints-to="usenet@ciao.gmane.io" Cc: salvino@coderedcorp.com, 51404@debbugs.gnu.org, 47291@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 11 16:09:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlBhg-0008fr-Eo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 16:09:28 +0100 Original-Received: from localhost ([::1]:54926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlBhf-00060c-He for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Nov 2021 10:09:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59244) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlBhG-0005pd-Hx for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 10:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlBhG-0007oK-8m for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 10:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mlBhG-0006qx-0K for bug-gnu-emacs@gnu.org; Thu, 11 Nov 2021 10:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Nov 2021 15:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47291 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47291-submit@debbugs.gnu.org id=B47291.163664329426247 (code B ref 47291); Thu, 11 Nov 2021 15:09:01 +0000 Original-Received: (at 47291) by debbugs.gnu.org; 11 Nov 2021 15:08:14 +0000 Original-Received: from localhost ([127.0.0.1]:41935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlBgU-0006pF-HI for submit@debbugs.gnu.org; Thu, 11 Nov 2021 10:08:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mlBgS-0006oy-W3; Thu, 11 Nov 2021 10:08:13 -0500 Original-Received: from [2001:470:142:3::e] (port=56760 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlBgM-0007VH-Cp; Thu, 11 Nov 2021 10:08:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bi9DzzxszVB6DzQl2QhPBI+fVguYZSfHEM/WjOAL138=; b=VCj1P6sEiy5T YSYbXFZZM33R9nuqF21XCZPsdGozP9+sp2qHoCZWIIdaHENb+gjoXWZ6ZKIAfVTy9Isxauleg2R5F qmBsz+JmJnvV2CsG1fnMvwIiiGvl+pIjnoF8cLeWZbbKL3EtaztypoBBNnJ6TfD94tkbxljCoWZIJ wE1poeRluPE1Zv40pC6GkD6hOEcZXn1FeONMCcDXa3j0DKNpkddWzROSxdrS/aq4d4H6HUAl0rdwE 1QbWyApMX1IVZ+Ej1EyDibuGStkZsikGEXL8vL12uCdFMNt+LNIeo8TRM0UnCMPN2k42rhV+4TSmd FYAIqgGqJKqBd2yHQQQCJg==; Original-Received: from [87.69.77.57] (port=2143 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlBgL-00071O-RT; Thu, 11 Nov 2021 10:08:06 -0500 In-Reply-To: <87wnle6g8o.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 11 Nov 2021 13:15:03 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219642 Archived-At: > From: Lars Ingebrigtsen > Cc: salvino@coderedcorp.com, 51404@debbugs.gnu.org, 47291@debbugs.gnu.org > Date: Thu, 11 Nov 2021 13:15:03 +0100 > > Eli Zaretskii writes: > > > I'm not sure unification is possible here, because the functionality > > is quite different, AFAICT. At least for the functionality in this > > bug report, we cannot apply the system theme to an existing frame, we > > can only apply it at frame creation time. So having a handler for > > such changes will be able to affect only the frames created after the > > change. Or at least that is my understanding; the code definitely > > applies the dark/light theme as part of creating a frame. > > Gtk Emacs doesn't respond to dark mode either -- so we have the > opportunity to decide how to handle these things across the board. > Perhaps in Gtk Emacs, dynamic-setting-handle-config-changed-event should > also just set something that will make the next frame creation use > different colours? If that's what people want, sure. I'd expect them to want Emacs to go to dark background on all frames. > > Also, having a dynamic thing that tracks changes in these settings > > would on Windows mean listening and processing a special window-system > > message, which seems to be WM_THEMECHANGED or maybe WM_SETTINGCHANGE. > > But that's not what the code installed in this bug report does. > > > > So the functionality seems similar, but the details differ. > > But perhaps Windows should be listening to those events, too? Maybe. But some expert (which is not me) will have to explain what to do when we receive these messages, or submit patches for that.