From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51940: 29.0.50; [PATCH] Fontification and indentation in M-x shell and ielm Date: Thu, 18 Nov 2021 13:16:33 +0200 Message-ID: <83ee7dyar2.fsf@gnu.org> References: <87sfvteqx2.fsf@miha-pc> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26668"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51940@debbugs.gnu.org To: miha@kamnitnik.top Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 18 12:18:03 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mnfQX-0006fJ-FN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 12:18:01 +0100 Original-Received: from localhost ([::1]:58286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mnfQV-0001j0-QJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Nov 2021 06:17:59 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48334) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnfPa-0000ne-Sl for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 06:17:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mnfPa-0004Lm-KA for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 06:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mnfPa-0002sH-Cc for bug-gnu-emacs@gnu.org; Thu, 18 Nov 2021 06:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Nov 2021 11:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51940-submit@debbugs.gnu.org id=B51940.163723420311009 (code B ref 51940); Thu, 18 Nov 2021 11:17:02 +0000 Original-Received: (at 51940) by debbugs.gnu.org; 18 Nov 2021 11:16:43 +0000 Original-Received: from localhost ([127.0.0.1]:34991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnfPH-0002rU-41 for submit@debbugs.gnu.org; Thu, 18 Nov 2021 06:16:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mnfPF-0002rA-Vv for 51940@debbugs.gnu.org; Thu, 18 Nov 2021 06:16:42 -0500 Original-Received: from [2001:470:142:3::e] (port=45068 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnfPA-0004I9-Fo; Thu, 18 Nov 2021 06:16:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Gvlr9N//trwkyOA69keHW9zoKLBzyj+K7o7vIvJk/j0=; b=dkm9/0Lmgp0B 7v+VE+t+U+7LLc2op2EucXali8s84EJVg2xgLdIgiL5SokOYnvqvPwcQyxbCjrXtysOuZb0GEAwE7 c6djWoMiVqqIozq7CGX9AuiDeoJeG9qQRY6IeASkdSAmB8Q0hcGdfniss4ASuLoIDrW3TFOu3mxkJ o+FTCffGiQMmDFHdoWOl9YB4QCC9rjEmQ4qZpOxMI/r2zJTODidXt4OfWnaN8qOy60S3S4lJ8aBLr eUwcTT9AAoPyFAbDCL1PqH7ArVNKtTcid1AGBE6gSX3Uyk6yVepg6JZsC7l5z5AMNCWlLl9BR+XOt tb/QgTA06LPgOsQWRQqsYA==; Original-Received: from [87.69.77.57] (port=3215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mnfPA-0008Ai-4F; Thu, 18 Nov 2021 06:16:36 -0500 In-Reply-To: <87sfvteqx2.fsf@miha-pc> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220308 Archived-At: > Date: Thu, 18 Nov 2021 10:47:37 +0100 > From: miha--- via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Please find the attached patches which enable fontification and > indentation in M-x shell and ielm. The main fontification and > indentation machinery is implemented in comint.el and should be general > enough for use by other comint derived modes. It works by making an > indirect buffer, putting it in a suitable major mode (sh-mode in > M-x shell buffers, for example) and fontifying and indenting user input > that buffer. Thanks. One general comment about the doc strings: > +(defvar-local comint-indirect-setup-function nil > + "Function to set up an indirect buffer. here and elsewhere in the changes, please modify the first sentence of the doc strings so that they don't sound too general. "Set up an indirect buffer" doesn't hint on the fact that this is for comint buffers, not in general about indirect buffers. The same problem exists with many doc strings in these patches.