bug#52331: M-$ doesn't respect subword mode

bug#52331: M-$ doesn't respect subword mode

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 346 bytes --]

To reproduce:

$ emacs --batch --eval "(global-subword-mode)" --eval "(insert
\"getBanana\")" --eval "(ispell-word)"

Expected output:
...
BANANA is correct

Expected output:
...
Checking spelling of GETBANANA...
C-h or ? for more options; SPC to leave unchanged, Character to replace word

Naturally, this also happens in interactive use.

Paul

[-- Attachment #2: Type: text/html, Size: 930 bytes --]

bug#52331: M-$ doesn't respect subword mode

[André A. Gomes]

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> To reproduce:
>
> $ emacs --batch --eval "(global-subword-mode)" --eval "(insert
> \"getBanana\")" --eval "(ispell-word)"
>
> Expected output:
> ...
> BANANA is correct
>
> Expected output:
> ...
> Checking spelling of GETBANANA... 

Thank you for the bug report.

There's only one speller checker that handles camelCase (AFAIK), which
is aspell since 0.60.8.  If you're using it, then you can add the
following to your init file:

(setq ispell-extra-args '("--camel-case"))

However, and the Emacs maintainers will probably agree, the
responsibility of sending the "right" word to the ispell sub-process
should be on Emacs' side.  I.e., when subword-mode is on, there should
be a call to word-at-point before sending it to the spell checker.


-- 
André A. Gomes
"Free Thought, Free World"

bug#52331: M-$ doesn't respect subword mode

[Eli Zaretskii]

> From: André A. Gomes <andremegafone@gmail.com>
> Date: Mon, 06 Dec 2021 16:34:43 +0000
> Cc: 52331@debbugs.gnu.org
> 
> > $ emacs --batch --eval "(global-subword-mode)" --eval "(insert
> > \"getBanana\")" --eval "(ispell-word)"
> >
> > Expected output:
> > ...
> > BANANA is correct
> >
> > Expected output:
> > ...
> > Checking spelling of GETBANANA... 
> 
> Thank you for the bug report.
> 
> There's only one speller checker that handles camelCase (AFAIK), which
> is aspell since 0.60.8.  If you're using it, then you can add the
> following to your init file:
> 
> (setq ispell-extra-args '("--camel-case"))
> 
> However, and the Emacs maintainers will probably agree, the
> responsibility of sending the "right" word to the ispell sub-process
> should be on Emacs' side.  I.e., when subword-mode is on, there should
> be a call to word-at-point before sending it to the spell checker.

It's not that easy, unfortunately.  ispell.el has its own rules for
what is a word, and the rules aren't static, they are determined
dynamically by the definition of the dictionary. That's because of at
least 2 reasons: (1) the rules must match what the dictionary
considers a word, and (2) spell-checking is expected to work in
buffers that mix several languages, so the rules need to be sensitive
to the language of the dictionary and reject "words" whose letters are
not part of the language.

So perhaps a better approach is to teach subword-mode about the word
rules of ispell.el, not the other way around.  Patches welcome.

bug#52331: M-$ doesn't respect subword mode

[André A. Gomes]

Eli Zaretskii <eliz@gnu.org> writes:

>> However, and the Emacs maintainers will probably agree, the
>> responsibility of sending the "right" word to the ispell sub-process
>> should be on Emacs' side.  I.e., when subword-mode is on, there should
>> be a call to word-at-point before sending it to the spell checker.
>
> It's not that easy, unfortunately.  ispell.el has its own rules for
> what is a word, and the rules aren't static, they are determined
> dynamically by the definition of the dictionary. That's because of at
> least 2 reasons: (1) the rules must match what the dictionary
> considers a word, and (2) spell-checking is expected to work in
> buffers that mix several languages, so the rules need to be sensitive
> to the language of the dictionary and reject "words" whose letters are
> not part of the language.

Correct, my comment was over simplistic.  But I don't see where my
reasoning fails.  I can't think of an example where calling
word-at-point before the ispell rules kick in would make harm.  What am
I missing?

> So perhaps a better approach is to teach subword-mode about the word
> rules of ispell.el, not the other way around.  Patches welcome.

I don't see how this could help.  Care to expand a bit?


--
André A. Gomes
"Free Thought, Free World"

bug#52331: M-$ doesn't respect subword mode

[Eli Zaretskii]

> From: André A. Gomes <andremegafone@gmail.com>
> Cc: pogonyshev@gmail.com,  52331@debbugs.gnu.org
> Date: Mon, 06 Dec 2021 17:21:28 +0000
> 
> > It's not that easy, unfortunately.  ispell.el has its own rules for
> > what is a word, and the rules aren't static, they are determined
> > dynamically by the definition of the dictionary. That's because of at
> > least 2 reasons: (1) the rules must match what the dictionary
> > considers a word, and (2) spell-checking is expected to work in
> > buffers that mix several languages, so the rules need to be sensitive
> > to the language of the dictionary and reject "words" whose letters are
> > not part of the language.
> 
> Correct, my comment was over simplistic.  But I don't see where my
> reasoning fails.  I can't think of an example where calling
> word-at-point before the ispell rules kick in would make harm.  What am
> I missing?

See ispell-get-word, I think it will explain what I meant.  This is
what ispell.el is using to determine what is a "word".

> > So perhaps a better approach is to teach subword-mode about the word
> > rules of ispell.el, not the other way around.  Patches welcome.
> 
> I don't see how this could help.  Care to expand a bit?

subword-mode uses regular expressions to find where the word begins
and ends.  Either use different regexps (derived from what ispell.el
uses) when spell-checking, or make ispell.el define its own
subword-forward/backward-functions for subword-mode to use instead of
its defaults.