From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53242: [PATCH] unify reads from local_var_alist Date: Sat, 15 Jan 2022 09:32:04 +0200 Message-ID: <83ee591mkr.fsf@gnu.org> References: <50d65dbc-f3d6-86fb-6a7c-9200a6525ec2@gmail.com> <83zgny20z2.fsf@gnu.org> <74db84b1-5433-dfb8-8ee3-9d86d8fc9be7@gmail.com> <83ilum16qq.fsf@gnu.org> <1e4edf7d-7f9c-ef56-7870-6f0f3567a40d@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3628"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53242@debbugs.gnu.org To: Sergey Vinokurov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 15 08:34:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8daC-0000pF-99 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 08:34:40 +0100 Original-Received: from localhost ([::1]:42204 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8daB-0005ja-3U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jan 2022 02:34:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8dYc-0005hH-6f for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 02:33:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45935) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8dYb-0001zu-Te for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 02:33:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8dYb-0004Fn-Ki for bug-gnu-emacs@gnu.org; Sat, 15 Jan 2022 02:33:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jan 2022 07:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53242 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 53242-submit@debbugs.gnu.org id=B53242.164223194616303 (code B ref 53242); Sat, 15 Jan 2022 07:33:01 +0000 Original-Received: (at 53242) by debbugs.gnu.org; 15 Jan 2022 07:32:26 +0000 Original-Received: from localhost ([127.0.0.1]:38838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8dY2-0004Et-HU for submit@debbugs.gnu.org; Sat, 15 Jan 2022 02:32:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8dY1-0004Eg-OB for 53242@debbugs.gnu.org; Sat, 15 Jan 2022 02:32:26 -0500 Original-Received: from [2001:470:142:3::e] (port=49678 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8dXw-0001G8-FO; Sat, 15 Jan 2022 02:32:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Ekc3Z7dSS4WwD+SlwNFx+0qFoV7grxHN2iNgW2idXC0=; b=rpVETwmP8iOU z2x79ouhlgIXve10bBAHccr2CrgH9WKxVahOBhdGCS4ieEJxtsJOuzFaAJmlgWzMrM2aTZ2hh8/I2 Rse/1Yv5TWRihAGbtVUmMc2AM81cvZq47glyFqWJLraM/b5bifN5Hq6BA9g3TwlLvtD1OdYuyWpgo dpLbKeGr4ReW/QKYSPlXJNBCTe6sm9dlnneVrOZOkryAuPd1isZY1MWGqNx0YZhOJPnFEcGQ9ixmu d7KDTPKKnZzYnyIirp9rc5O2dYQUaGZR/M+wbWqAphuEvBTx1TI1aOC/vc4Pmc1QZgg6K1aJssv6M cWSj4jMMDYeq6gUvcsaQgQ==; Original-Received: from [87.69.77.57] (port=4441 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8dXw-0001dx-HO; Sat, 15 Jan 2022 02:32:20 -0500 In-Reply-To: <1e4edf7d-7f9c-ef56-7870-6f0f3567a40d@gmail.com> (message from Sergey Vinokurov on Fri, 14 Jan 2022 21:01:46 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224244 Archived-At: > Date: Fri, 14 Jan 2022 21:01:46 +0000 > Cc: 53242@debbugs.gnu.org > From: Sergey Vinokurov > > I argue that something's wrong if there are so many local variables > defined that lookups into the local_var_alist would cause > significant delays. I agree that something is wrong, in the sense that the implementation of some feature(s) should probably be rethought. But that's not the point I'm trying to make. The point I'm trying to make is that formerly, the user could interrupt such a long search, and now he/she cannot. The user is usually not the one to "blame" for the length of the list. With the previous code, the user had a "fire escape". > My argument is that at this point we don't care whether user is able > to interrupt basic operations of reading and writing buffer-local > variables. "We" might not care, but the user could very much care. We in effect locked the users without no way to handle these situations. > Even if we use Fassq and the user could interrupt, nothing is gained > in my opinion - any command that involves reading or writing > buffer-local variables will still remain slow. The commands will remain slow, but the users could stop Emacs from wasting their time. Now they cannot. Saying that "we don't care" means we don't care about our users, which is certainly not true.