unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Sergey Vinokurov <serg.foo@gmail.com>
Cc: 53242@debbugs.gnu.org
Subject: bug#53242: [PATCH] unify reads from local_var_alist
Date: Sat, 15 Jan 2022 09:32:04 +0200	[thread overview]
Message-ID: <83ee591mkr.fsf@gnu.org> (raw)
In-Reply-To: <1e4edf7d-7f9c-ef56-7870-6f0f3567a40d@gmail.com> (message from Sergey Vinokurov on Fri, 14 Jan 2022 21:01:46 +0000)

> Date: Fri, 14 Jan 2022 21:01:46 +0000
> Cc: 53242@debbugs.gnu.org
> From: Sergey Vinokurov <serg.foo@gmail.com>
> 
> I argue that something's wrong if there are so many local variables
> defined that lookups into the local_var_alist would cause
> significant delays.

I agree that something is wrong, in the sense that the implementation
of some feature(s) should probably be rethought.  But that's not the
point I'm trying to make.  The point I'm trying to make is that
formerly, the user could interrupt such a long search, and now he/she
cannot.  The user is usually not the one to "blame" for the length of
the list.  With the previous code, the user had a "fire escape".

> My argument is that at this point we don't care whether user is able
> to interrupt basic operations of reading and writing buffer-local
> variables.

"We" might not care, but the user could very much care.  We in effect
locked the users without no way to handle these situations.

> Even if we use Fassq and the user could interrupt, nothing is gained
> in my opinion - any command that involves reading or writing
> buffer-local variables will still remain slow.

The commands will remain slow, but the users could stop Emacs from
wasting their time.  Now they cannot.  Saying that "we don't care"
means we don't  care about our users, which is certainly not true.





  reply	other threads:[~2022-01-15  7:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-14  0:23 bug#53242: [PATCH] unify reads from local_var_alist Sergey Vinokurov
2022-01-14  7:49 ` Lars Ingebrigtsen
2022-01-14  8:08 ` Eli Zaretskii
2022-01-14  8:33   ` Lars Ingebrigtsen
2022-01-14 18:37   ` Sergey Vinokurov
2022-01-14 19:01     ` Eli Zaretskii
2022-01-14 21:01       ` Sergey Vinokurov
2022-01-15  7:32         ` Eli Zaretskii [this message]
2022-01-15 11:41           ` Sergey Vinokurov
2022-01-15 16:02             ` Corwin Brust
2022-01-15 17:54               ` Sergey Vinokurov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ee591mkr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=53242@debbugs.gnu.org \
    --cc=serg.foo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).