From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55156: [PATCH] eval.c: New functions `defvar-f` and `defconst-f` Date: Thu, 28 Apr 2022 16:45:47 +0300 Message-ID: <83ee1hb9tg.fsf@gnu.org> References: <83sfpxbwkg.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55156@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 28 15:47:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nk4Ub-00083M-Vs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 15:47:38 +0200 Original-Received: from localhost ([::1]:50346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nk4Ua-00046R-KV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Apr 2022 09:47:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51126) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4T4-0000f3-E1 for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51959) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nk4T4-0003pj-5N for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nk4T4-0006Lr-3K for bug-gnu-emacs@gnu.org; Thu, 28 Apr 2022 09:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Apr 2022 13:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55156 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55156-submit@debbugs.gnu.org id=B55156.165115355724096 (code B ref 55156); Thu, 28 Apr 2022 13:46:02 +0000 Original-Received: (at 55156) by debbugs.gnu.org; 28 Apr 2022 13:45:57 +0000 Original-Received: from localhost ([127.0.0.1]:45856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4Sy-0006GO-FY for submit@debbugs.gnu.org; Thu, 28 Apr 2022 09:45:56 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nk4Sv-00068H-V7 for 55156@debbugs.gnu.org; Thu, 28 Apr 2022 09:45:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4Sq-0003im-LB; Thu, 28 Apr 2022 09:45:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LcRpwaFaPPgxZVdMKjSnL1rg7RJzRPp0DnhsJftEtEU=; b=jpTwESTCo86y 7p/BO60DFbYlzPAby6C0HQB4V1g8FBwCscqWddkPET/TdHMEVsaORdjlSbPlWU/hLBwWnUM1byyLU 8T94GzRx0pzXH/pYduOZUfE2MlXgE3fdnQjHSuhxKbMaLbVFW9s1AGTIA2DKgrwxENyj6Z96pqYJ0 C4uf+5JFIRDK+Mcc9CnEUn0RzDDFVsoMq+1bV3rlUHnR6weAuP5ve7FBMVVpvhKNkl3/2qX8H/mLQ SoE34IGzybwmf8ijfsTru9Pl0g0mT3IEkl3unXsCMcB3Yoc4b/0SGvLf6f85ycQbXM+ZahPH+wY/1 1vJxs/NXjuY9AKTjstRTaQ==; Original-Received: from [87.69.77.57] (port=3126 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nk4Sq-00024X-55; Thu, 28 Apr 2022 09:45:48 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 28 Apr 2022 09:26:50 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230881 Archived-At: > From: Stefan Monnier > Cc: 55156@debbugs.gnu.org > Date: Thu, 28 Apr 2022 09:26:50 -0400 > > >> +DEFUN ("defvar-f", Fdefvar_f, Sdefvar_f, 2, 3, 0, > >> + doc: /* Like `defvar' but as a function. */) > > > > Please improve the doc string here. > > > >> +DEFUN ("defconst-f", Fdefconst_f, Sdefconst_f, 2, 3, 0, > >> + doc: /* Like `defconst' but as a function. */) > > > > Likewise. > > How 'bout I use a double dash to make it more clear they're internal? It should still say something about its intended usage, with Emacs developers in mind, IMO. Because I doubt that we are going to document them in the ELisp reference manual, and nor do I think we should. So this place here is the only place where we can say something about these functions, so that future hackers of the byte compiler could maintain this.