From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Date: Thu, 02 Jun 2022 22:19:24 +0300 Message-ID: <83ee06euv7.fsf@gnu.org> References: <87leuqkmhl.fsf@posteo.org> <9e283838-aaa1-345e-bce8-21ee863dbc31@yandex.ru> <43b5eada954e592cc0c747368a3dbdb7@posteo.de> <437b78f7-f4a9-670d-9b74-69ae8a565767@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6558"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55632@debbugs.gnu.org, raaahh@gmail.com, dgutov@yandex.ru To: jan.synacek@posteo.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 02 21:20:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwqN0-0001aJ-SN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jun 2022 21:20:35 +0200 Original-Received: from localhost ([::1]:41720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwqMz-0005iL-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Jun 2022 15:20:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37024) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwqMV-0005gT-2M for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2022 15:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwqMU-0005FJ-Pg for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2022 15:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwqMU-0002dv-FY for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2022 15:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Jun 2022 19:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55632-submit@debbugs.gnu.org id=B55632.165419756510099 (code B ref 55632); Thu, 02 Jun 2022 19:20:02 +0000 Original-Received: (at 55632) by debbugs.gnu.org; 2 Jun 2022 19:19:25 +0000 Original-Received: from localhost ([127.0.0.1]:54642 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwqLs-0002cp-MP for submit@debbugs.gnu.org; Thu, 02 Jun 2022 15:19:24 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwqLp-0002cL-Ne for 55632@debbugs.gnu.org; Thu, 02 Jun 2022 15:19:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwqLj-0005A3-3x; Thu, 02 Jun 2022 15:19:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kI5Raw4+5k1J91RLwIje8MAsQseR5VV1oKpQTV6qWOA=; b=bPZvVBF6E2qT KUrjXEXpCbgBWaW+2im9oeq4cW4FthMIQ0bQyTs9kWBe9wev5bsTUcocwCvZeNBafoGeP2xNtd6cv nnzvWzshCd4EEN6oqbo/SMca1xFXpTY+jfBJCl+etg9z2I2kw27DTjhpQ5J7wc/S+DYXKQj7jDVPy QoWbZLp2uT3wjyFy/C/+sXeu/hUDejduYIqVwak2TdNvQfcN/+tTydKpdutDzlv2OtvGivb5gvcKL yTvU+AgYp0fXaXjlhqgqHHs/M3a4q967xi5GZ0cyFvXIY1K+TY1z7WUTog+N9icIRJEatczdft5Xe 20lh4yjtoSYYo+Kn0ZPF6w==; Original-Received: from [87.69.77.57] (port=2889 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwqLi-0007Ob-KC; Thu, 02 Jun 2022 15:19:14 -0400 In-Reply-To: (jan.synacek@posteo.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233568 Archived-At: > Cc: 55632@debbugs.gnu.org, DG > Date: Thu, 02 Jun 2022 19:01:53 +0000 > From: jan.synacek@posteo.org > > ++++ > +*** New user option 'project-vc-include-untracked'. > +When non-nil, the VC project backend includes the untracked files. Can we please tell more about what does "include untracked files" mean? Include where and in what sense? Bonus points for explaining this without ever alluding to "backend", as that is not necessarily a user-level concept in this case. Also, is it "VC project backend" or "Project's VC backend"? > +(defcustom project-vc-include-untracked t > + "When non-nil, the VC project backend includes the untracked files." > + :type 'boolean > + :safe #'booleanp) Same here. And new defcustom's should have a :version tag. > - ;; Include unregistered. > - (setq args (append args '("-c" "-o" "--exclude-standard"))) > + (setq args (append args > + '("-c" "--exclude-standard") > + (when project-vc-include-untracked '("-o")))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ I think 'when' is overkill here, because 'if' will do the job. > - ;; Include unregistered. > - (setq args (nconc args '("-mcardu" "--no-status" "-0"))) > + (args (list (concat "-mcard" (when project-vc-include-untracked "u")) > + "--no-status" > + "-0"))) Likewise here. Thank you for working on this.