From: Eli Zaretskii <eliz@gnu.org>
To: jan.synacek@posteo.org
Cc: 55632@debbugs.gnu.org, raaahh@gmail.com, dgutov@yandex.ru
Subject: bug#55632: [PATCH] Add new user option project-vc-find-tracked-only
Date: Thu, 02 Jun 2022 22:19:24 +0300 [thread overview]
Message-ID: <83ee06euv7.fsf@gnu.org> (raw)
In-Reply-To: <a1687a401198bc19f992af8a599074cd@posteo.de> (jan.synacek@posteo.org)
> Cc: 55632@debbugs.gnu.org, DG <raaahh@gmail.com>
> Date: Thu, 02 Jun 2022 19:01:53 +0000
> From: jan.synacek@posteo.org
>
> ++++
> +*** New user option 'project-vc-include-untracked'.
> +When non-nil, the VC project backend includes the untracked files.
Can we please tell more about what does "include untracked files"
mean? Include where and in what sense? Bonus points for explaining
this without ever alluding to "backend", as that is not necessarily a
user-level concept in this case.
Also, is it "VC project backend" or "Project's VC backend"?
> +(defcustom project-vc-include-untracked t
> + "When non-nil, the VC project backend includes the untracked files."
> + :type 'boolean
> + :safe #'booleanp)
Same here. And new defcustom's should have a :version tag.
> - ;; Include unregistered.
> - (setq args (append args '("-c" "-o" "--exclude-standard")))
> + (setq args (append args
> + '("-c" "--exclude-standard")
> + (when project-vc-include-untracked '("-o"))))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I think 'when' is overkill here, because 'if' will do the job.
> - ;; Include unregistered.
> - (setq args (nconc args '("-mcardu" "--no-status" "-0")))
> + (args (list (concat "-mcard" (when project-vc-include-untracked "u"))
> + "--no-status"
> + "-0")))
Likewise here.
Thank you for working on this.
next prev parent reply other threads:[~2022-06-02 19:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 9:08 bug#55632: [PATCH] Add new user option project-vc-find-tracked-only Jan Synáček
2022-05-27 11:01 ` Lars Ingebrigtsen
2022-05-27 13:55 ` Dmitry Gutov
2022-05-29 21:41 ` Dmitry Gutov
2022-05-30 11:00 ` jan.synacek
2022-05-31 22:49 ` Dmitry Gutov
2022-06-02 19:01 ` jan.synacek
2022-06-02 19:19 ` Eli Zaretskii [this message]
2022-06-02 23:45 ` Dmitry Gutov
2022-06-03 5:44 ` Eli Zaretskii
2022-06-04 0:37 ` Dmitry Gutov
2022-06-04 6:29 ` Eli Zaretskii
2022-06-04 9:40 ` Dmitry Gutov
2022-05-30 10:08 ` jan.synacek
2022-05-31 22:57 ` Dmitry Gutov
2022-06-01 15:21 ` jan.synacek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ee06euv7.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55632@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=jan.synacek@posteo.org \
--cc=raaahh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).