From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase Date: Fri, 10 Jun 2022 08:52:45 +0300 Message-ID: <83edzx12vm.fsf@gnu.org> References: <37af046b-4257-6370-c765-9290eae73fd4@gmail.com> <831qw6dzra.fsf@gnu.org> <0278e759-237b-a32b-4b1f-fbdacf39c8ef@gmail.com> <83pmjpar0x.fsf@gnu.org> <9e8a8b42-2f42-3027-2ec0-97744bb91911@gmail.com> <83sfoja2xp.fsf@gnu.org> <34062848-8fe4-351c-df63-5cc341fefa57@gmail.com> <83sfoj7x6f.fsf@gnu.org> <83ee027yjc.fsf@gnu.org> <2b86123e-76c1-ec0c-c767-7d821473e5e1@gmx.at> <86a0c66e-86f9-6bd6-2010-eb1cf2d9f1e6@gmail.com> <83a6am47v6.fsf@gnu.org> <4abda9a0-7c34-cdad-fc9e-a6dc25e7c74b@gmail.com> <837d5p3hr7.fsf@gnu.org> <8e4fc184-8ca1-8094-f37d-f77d0cbb337c@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17163"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 10 07:53:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzXa8-0004J7-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 07:53:17 +0200 Original-Received: from localhost ([::1]:33584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nzXa7-0006cs-T2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jun 2022 01:53:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44124) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzXZu-0006cd-KO for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 01:53:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54548) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nzXZu-0004Qu-BC for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 01:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nzXZu-0005Bp-9S for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2022 01:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2022 05:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55696 X-GNU-PR-Package: emacs Original-Received: via spool by 55696-submit@debbugs.gnu.org id=B55696.165484038119942 (code B ref 55696); Fri, 10 Jun 2022 05:53:02 +0000 Original-Received: (at 55696) by debbugs.gnu.org; 10 Jun 2022 05:53:01 +0000 Original-Received: from localhost ([127.0.0.1]:48445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzXZs-0005Ba-Nw for submit@debbugs.gnu.org; Fri, 10 Jun 2022 01:53:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nzXZk-0005BG-BG for 55696@debbugs.gnu.org; Fri, 10 Jun 2022 01:52:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzXZf-0004PH-0p; Fri, 10 Jun 2022 01:52:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dLdApXjDu98CSANeoQLfUB0/F+mLMBSV6u+P7TxWjIA=; b=JZaAvqSQYGSr JKH6TQ9aCo3h/bzCGyzm0Xx5jljXgZFX/kH5QutUlHmJgm03jB5aim5uy3lrk4lggiYWDeEJryj5v kffObywZpT2xxjdfzPzzEwBgVPOhETQHidBA6aDs2DCgnZAk4OiIC1uiMoBRM4J4Olglh/S2JDECN U6uuJEc1nShwQSFMdHBExV+/lqnq12bLZQ6BYaWbOZi3t/CBjCYI/hs8hVCwLUiM0k2DwnBYDfQj4 YqREunreD096zDCqUBolaYG/G5yrKGPn3ZgEsxssKalzsCfUe8J3QHAyQkqDCKrqcOmw9nKNIi6Ko vevIWIf3Y2ZkaDy7h5Xlgw==; Original-Received: from [87.69.77.57] (port=3979 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nzXZe-0004X4-GS; Fri, 10 Jun 2022 01:52:46 -0400 In-Reply-To: <8e4fc184-8ca1-8094-f37d-f77d0cbb337c@gmail.com> (message from Jim Porter on Thu, 9 Jun 2022 15:14:22 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234185 Archived-At: > Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com > From: Jim Porter > Date: Thu, 9 Jun 2022 15:14:22 -0700 > > > If I make this replacement in 4 tests that use "list", then it doesn't > > hang, but 2 tests fail: > > That makes sense. Those other tests that are now failing should stay > unchanged. The difference is in the brace style of the commands. > > For `esh-var-test/interp-lisp-indices': the expansion is '$(list 1 2)', > which means "evaluate '(list 1 2)' as a Lisp sexpr". This doesn't need > to change. > > For `esh-var-test/interp-cmd-indices': the expansion is '${list 1 2}', > which means "evaluate 'list 1 2' as a shell-like command". In this case, > if there's an external program named 'list', it will call that; > otherwise, it will call the Lisp function `list'. (If there were a Lisp > function named `eshell/list', Eshell would always prefer that.) Here, we > should use 'listify', since it's the preferred Eshell way to make a list > using command-style syntax. What if there's an external command named 'listify' -- is there any chance that the test will invoke it? If so, I think we should come up with a safer solution. Otherwise, feel free to install the change, and thanks.