From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
Subject: bug#55696: 28.1; eshell fails to respect text-scale-increase
Date: Fri, 10 Jun 2022 08:52:45 +0300 [thread overview]
Message-ID: <83edzx12vm.fsf@gnu.org> (raw)
In-Reply-To: <8e4fc184-8ca1-8094-f37d-f77d0cbb337c@gmail.com> (message from Jim Porter on Thu, 9 Jun 2022 15:14:22 -0700)
> Cc: 55696@debbugs.gnu.org, jeff.kowalski@gmail.com
> From: Jim Porter <jporterbugs@gmail.com>
> Date: Thu, 9 Jun 2022 15:14:22 -0700
>
> > If I make this replacement in 4 tests that use "list", then it doesn't
> > hang, but 2 tests fail:
>
> That makes sense. Those other tests that are now failing should stay
> unchanged. The difference is in the brace style of the commands.
>
> For `esh-var-test/interp-lisp-indices': the expansion is '$(list 1 2)',
> which means "evaluate '(list 1 2)' as a Lisp sexpr". This doesn't need
> to change.
>
> For `esh-var-test/interp-cmd-indices': the expansion is '${list 1 2}',
> which means "evaluate 'list 1 2' as a shell-like command". In this case,
> if there's an external program named 'list', it will call that;
> otherwise, it will call the Lisp function `list'. (If there were a Lisp
> function named `eshell/list', Eshell would always prefer that.) Here, we
> should use 'listify', since it's the preferred Eshell way to make a list
> using command-style syntax.
What if there's an external command named 'listify' -- is there any
chance that the test will invoke it? If so, I think we should come up
with a safer solution.
Otherwise, feel free to install the change, and thanks.
next prev parent reply other threads:[~2022-06-10 5:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-29 3:43 bug#55696: 28.1; eshell fails to respect text-scale-increase Jeff Kowalski
2022-06-03 4:41 ` Jim Porter
2022-06-03 6:31 ` Eli Zaretskii
2022-06-03 20:30 ` Jim Porter
2022-06-04 6:20 ` Eli Zaretskii
2022-06-05 4:49 ` Jim Porter
2022-06-05 9:13 ` Eli Zaretskii
2022-06-05 18:12 ` Jim Porter
2022-06-05 19:00 ` Eli Zaretskii
2022-06-05 19:59 ` Jim Porter
2022-06-06 12:43 ` Eli Zaretskii
2022-06-07 3:04 ` Jim Porter
2022-06-07 10:55 ` Eli Zaretskii
2022-06-08 8:07 ` martin rudalics
2022-06-08 23:20 ` Jim Porter
2022-06-09 7:24 ` Eli Zaretskii
2022-06-09 15:55 ` Jim Porter
2022-06-09 16:48 ` Eli Zaretskii
2022-06-09 22:14 ` Jim Porter
2022-06-10 5:52 ` Eli Zaretskii [this message]
2022-06-10 15:44 ` Jim Porter
2022-06-10 15:58 ` Eli Zaretskii
2022-06-10 16:44 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83edzx12vm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55696@debbugs.gnu.org \
--cc=jeff.kowalski@gmail.com \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).