From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Mon, 01 Aug 2022 16:24:00 +0300 Message-ID: <83edy02j2n.fsf@gnu.org> References: <83zggwcby5.fsf@gnu.org> <83o7xccagi.fsf@gnu.org> <831qu7daxb.fsf@gnu.org> <83sfmnb7yg.fsf@gnu.org> <837d3ybh5z.fsf@gnu.org> <136c4fe0fc74196714aa@heytings.org> <83pmhp89ov.fsf@gnu.org> <136c4fe0fc39573addc9@heytings.org> <83k07x8738.fsf@gnu.org> <136c4fe0fcdf00ef9a11@heytings.org> <83h73183r7.fsf@gnu.org> <136c4fe0fc0fceb0d752@heytings.org> <838roc8ka7.fsf@gnu.org> <83tu706obt.fsf@gnu.org> <83h7306ifa.fsf@gnu.org> <83edy37pul.fsf@gnu.org> <83pmhn55sk.fsf@gnu.org> <65cb7c73fdc753518d35@heytings.org> <83fsii68o3.fsf@gnu.org> <65cb7c73fdf6704d19d5@heytings.org> <835yje62vz.fsf@gnu.org> <83r1214uz5.fsf@gnu.org> <8c7321f2f39b7a28dd18@heytings.org> <83o7x42l64.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29711"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 01 15:42:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIVgf-0007Xx-Sv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 15:42:25 +0200 Original-Received: from localhost ([::1]:34140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oIVge-0005Kd-Ra for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Aug 2022 09:42:24 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIVPs-0008Ok-Kr for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 09:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIVPq-0000sR-5Q for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 09:25:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oIVPp-0003Ow-VQ for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 09:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Aug 2022 13:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.165936027413014 (code B ref 56682); Mon, 01 Aug 2022 13:25:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 1 Aug 2022 13:24:34 +0000 Original-Received: from localhost ([127.0.0.1]:39744 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIVPN-0003Nq-HE for submit@debbugs.gnu.org; Mon, 01 Aug 2022 09:24:33 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIVP7-0003NI-8y for 56682@debbugs.gnu.org; Mon, 01 Aug 2022 09:24:31 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIVP1-0000kh-Ti; Mon, 01 Aug 2022 09:24:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YCJaFyUp9TmX0h+mnsMZbVCJTSL6SIg+SxoUYBk+O8I=; b=MJaIO7gM8ziJ QqWh9F8UsOpieGWV8mOvfwF0REXMt6lLTOnMuC34KGdY8drsAoG33Ee0Sn4yLEXonjIBpK+oun/JJ lZ7WeUKwJF8BnuzEqTHdmCvFireRrjmPVa2H8BiHfQKoEDVWukrzpnxYQbU6f5KEEo1wC+uplbecy naNrQBtp9Ss7G+JwRHk142E9ZdD+fYRpUvcYL7WfwmxgPh1qTHXaRXuaOZrKaJJMgM7JLOTzk3+d2 gCKTL91UOAbFoQrbELawj8dQpR3EvrgSpkbxsETyf1nccQyprZ7lwjvzy39lmh9ezRFZ7t3cNIwD2 Vv6YGGc+uKpXQIIYyCZCQQ==; Original-Received: from [87.69.77.57] (port=2995 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIVP1-00059u-Cm; Mon, 01 Aug 2022 09:24:11 -0400 In-Reply-To: (message from Gregory Heytings on Mon, 01 Aug 2022 12:51:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238437 Archived-At: > Date: Mon, 01 Aug 2022 12:51:47 +0000 > From: Gregory Heytings > cc: gerd.moellmann@gmail.com, 56682@debbugs.gnu.org, larsi@gnus.org, > monnier@iro.umontreal.ca > > diff --git a/src/xdisp.c b/src/xdisp.c > index 8a19b3bda9..9574d06bd5 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -3472,6 +3472,9 @@ init_iterator (struct it *it, struct window *w, > &it->bidi_it); > } > > + if (current_buffer->long_line_optimizations_p) > + it->narrowed_begv = 0; > + Sorry, I wrote that this is OK, but it isn't: if init_iterator is called with 'struct it' that was already initialized by a previous call to 'reseat', the above will nuke the narrowing. So we need something more complicated. ATM I don't see how to solve this without manually initializing narrowed_begv before the first call to init_iterator or start_display. Hmm...