From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Date: Thu, 04 Aug 2022 09:53:32 +0300 Message-ID: <83edxw4hzn.fsf@gnu.org> References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7390"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56896@debbugs.gnu.org To: Jim Porter , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 04 08:54:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJUkf-0001kn-DI for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Aug 2022 08:54:37 +0200 Original-Received: from localhost ([::1]:51484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oJUkd-00074q-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Aug 2022 02:54:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33542) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJUk6-00073i-St for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 02:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32956) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJUk6-0006P2-I7 for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 02:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oJUk6-0000ZR-Bx for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 02:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Aug 2022 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16595960262170 (code B ref 56896); Thu, 04 Aug 2022 06:54:02 +0000 Original-Received: (at 56896) by debbugs.gnu.org; 4 Aug 2022 06:53:46 +0000 Original-Received: from localhost ([127.0.0.1]:50938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUjq-0000Yv-8t for submit@debbugs.gnu.org; Thu, 04 Aug 2022 02:53:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUjm-0000Ye-NG for 56896@debbugs.gnu.org; Thu, 04 Aug 2022 02:53:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJUjh-0006OG-Bl; Thu, 04 Aug 2022 02:53:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YDIeaiZQLeue01n1PXST+1TZrFNt2UtQd8LFx5PN65g=; b=NgWUxjSaJ9p3 oAFYQkhNAyj/PbxkRJbi3SYiMevjPnCacUPUcIO3YW2Rp+AhOgo7lr2MrNr4vM8UIEpD1NQ3lPXRy TpJRKUla7pXjddYLiq3m87QumRFjHSWgnzONAydBd8lINBSO1xAe9geUHXzLmKUeFT9DhQ4yEzt1H yAdMulaIfxg+k3X5jiShS+fTdUXGd6Plj5YLdUrZxhJPCiz1L8Wl4OrU8X4I8wzq+6VXrq3Q3nCk2 dVmJQ8XUcmP47iGGh0TskSe1Z7auPo+t7BFoePy3GNwa0JYf52sQhp9yUdaAodsu7XcR9LsuPGo8W czj34rxt2dVasqTSMlQncw==; Original-Received: from [87.69.77.57] (port=1690 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJUjg-0001Uz-8f; Thu, 04 Aug 2022 02:53:36 -0400 In-Reply-To: <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> (message from Jim Porter on Wed, 3 Aug 2022 20:24:24 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238685 Archived-At: > Cc: 56896@debbugs.gnu.org > From: Jim Porter > Date: Wed, 3 Aug 2022 20:24:24 -0700 > > > Not sure if we need a general capability as in 3), but if it can be > > implemented cleanly and will be convenient for user options, I don't > > see why not. > > How does this look? I added a new built-in fringe bitmap > ('large-circle'), since it should be generally-useful. There are a > couple different fringe bitmaps for breakpoints that could use this, but > I didn't do anything about that in this patch. > > I also added a Customize widget to let users pick a fringe bitmap. I'm > not super-familiar with Customize, so I just guessed on how this is > supposed to be defined (I based it on the 'font' widget). Reading the code, it LGTM. But I'm not familiar enough with the Customize parts of the patch, so let's wait a bit for others to chime in. Lars, WDYT? > Finally, I adjusted the names of a couple bookmark variables and let > users specify a bitmap (or nil) for 'bookmark-fringe-mark'. Note that > changing this (via Customize or not) doesn't force an update of > already-set bookmark fringe marks. That would be nice to have, but I'd > need to study the code quite a bit more to figure out how to do this. I think we should fix this aspect, yes. So please do try to find the way of doing it with some kind of :set function. > If this seems about right, I'll add a NEWS entry describing the change > (though I welcome any feedback about how much should go in NEWS; I'm not > 100% sure). If there's a detailed enough description in the manual(s), the NEWS entry can be quite short, just mentioning the new capabilities and variables. If you don't think this is manual-worthy, the NEWS entry should be a bit more detailed. But don't worry about that, we will get to it when you submit the actual text for NEWS. Thanks.