From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists Date: Sat, 19 Nov 2022 15:12:10 +0200 Message-ID: <83edtz84wl.fsf@gnu.org> References: <87wn7ujpdh.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1455"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, jonas@bernoul.li, 59328@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 19 14:13:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owNen-0000Cc-Vv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Nov 2022 14:13:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owNeZ-0006VM-FF; Sat, 19 Nov 2022 08:13:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owNeY-0006VE-E6 for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 08:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owNeY-0003Dd-6F for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 08:13:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1owNeX-00059W-VF for bug-gnu-emacs@gnu.org; Sat, 19 Nov 2022 08:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Nov 2022 13:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59328 X-GNU-PR-Package: emacs Original-Received: via spool by 59328-submit@debbugs.gnu.org id=B59328.166886353719754 (code B ref 59328); Sat, 19 Nov 2022 13:13:01 +0000 Original-Received: (at 59328) by debbugs.gnu.org; 19 Nov 2022 13:12:17 +0000 Original-Received: from localhost ([127.0.0.1]:39229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owNdp-00058Y-8M for submit@debbugs.gnu.org; Sat, 19 Nov 2022 08:12:17 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1owNdi-00058H-VT for 59328@debbugs.gnu.org; Sat, 19 Nov 2022 08:12:15 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owNdd-00038L-JR; Sat, 19 Nov 2022 08:12:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/kr3Wvve7OLT9vZMHjIQWDpCpA1bulw8nB74VB1CLA8=; b=F3vj7L5+jCPk M3ME8C7AxWzMi4LGC+AXk6QKsbyxdnUcxZ9zRtDWN0JH09/YYWlkqpRwBJnd+3wdL/P9t36cT/5fo T5qSP8uKJzHKTwk84oPCAH8R9pfV3XjZSjlOIuskFv7m0fvyJuDG9Esx/gsryB9IIebFXodvZlvx5 kNOJqhFWglKCwG4ZsqkgCi2Kcf97ysjb0Mcd8WCjQQl08ypYCP420VAbtaKXHpwoj7OL40bG/nudd A8eqc8KZG7ywb/qrXJX3dB9UUT++g56Z8GwVWYSYGau+lJ9hrh4ifh19diPobSou8tZn0bf30gAX9 PVUMZOOGEY2FEHQLDqWxLQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owNdc-0004Ar-Sf; Sat, 19 Nov 2022 08:12:05 -0500 In-Reply-To: <87wn7ujpdh.fsf@web.de> (message from Michael Heerdegen on Thu, 17 Nov 2022 03:17:46 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248335 Archived-At: > Cc: Lars Ingebrigtsen , Jonas Bernoulli > From: Michael Heerdegen > Date: Thu, 17 Nov 2022 03:17:46 +0100 > > The current implementation of the (non-generic!) function `seq-keep': > > #+begin_src emacs-lisp > (defun seq-keep (function sequence) > (delq nil (seq-map function sequence))) > ;; ^^^^ > #+end_src > > obviously only works when `seq-map' returns a list. This is the case > for the default implementation of the generic function `seq-map' but not > necessarily for other implementations of `seq-map'. > > We need to filter out the `nil' elements with a way appropriate for any > sequence type supported by "seq.el" (i.e. with a generic function > defined in this lib), e.g. > > #+begin_src emacs-lisp > (defun seq-keep (function sequence) > (seq-filter #'identity (seq-map function sequence))) > #+end_src This makes sense to me, so please go ahead and install, preferably with a test for non-list cases. > BTW, is the name a good one? Why "keep"? It returns a sequence of > potentially all completely different elements. And is the function that > useful and a good abstraction at all (I don't have thought about it > too long...)? FWIW, "keep" doesn't sound problematic to me. Thanks.