unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gabriel <gabriel376@hotmail.com>, Tassilo Horn <tsdh@gnu.org>
Cc: 59527@debbugs.gnu.org
Subject: bug#59527: 29.0.50; Face issues in show-paren context overlay
Date: Thu, 24 Nov 2022 09:10:54 +0200	[thread overview]
Message-ID: <83edtsyght.fsf@gnu.org> (raw)
In-Reply-To: <SJ0PR06MB86096892237D8E21745E1D848B0F9@SJ0PR06MB8609.namprd06.prod.outlook.com> (message from Gabriel on Wed, 23 Nov 2022 21:22:02 -0300)

> From: Gabriel <gabriel376@hotmail.com>
> Date: Wed, 23 Nov 2022 21:22:02 -0300
> 
> The context overlay (from show-paren) has some face issues.  First, in
> case font-lock was not applied to a previous region of the buffer, the
> overlay will not display the context with font-lock.  Second, the
> overlay will be displayed with the same background as the top-left line
> of the window instead of the original context background.
> 
> Steps:
> 
> 1) emacs -Q (master "b42cd524b46a4f29ef13e9d03be9d3df917f9aa3")
> 
> 2) eval:
> 
> (progn
>     ;; enable overlay context in show-paren
>     (setopt show-paren-context-when-offscreen 'overlay)
> 
>     ;; just to have a different background to reproduce issue #2
>     (add-hook 'c-mode-hook #'whitespace-mode))
> 
> 3) Open file src/xdisp.c from emacs source tree: C-x C-f emacs/src/xdisp.c
> 
> 4) Go to line 13418: M-g M-g 13418
> 
> 5) Go to next char (the context overlay will be displayed): C-f
> 
> Problem 1: the overlay context does not have font-lock, since font-lock
> was not applied to the previous area that contains the context.  As a
> workaround, execute C-M b (to navigate to context and force font-lock
> update) and then C-M-f to navigate back and display again the overlay
> context (with correct font-lock, this time).  I expect the context
> overlay to always be displayed with an updated font-lock.
> 
> Problem 2: the overlay context will be displayed with the same
> background color as the top-left line of the window (yellow, in this
> case, because of whitespace-mode).  I expect the context overlay to
> always show the correct background, regardless of the face in the
> top-left line.

CC'ing Tassilo, who implemented this feature.





  reply	other threads:[~2022-11-24  7:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24  0:22 bug#59527: 29.0.50; Face issues in show-paren context overlay Gabriel
2022-11-24  7:10 ` Eli Zaretskii [this message]
2022-11-24  7:18   ` Tassilo Horn
2022-11-24  9:55   ` Tassilo Horn
2022-11-24 11:21     ` Gabriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83edtsyght.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59527@debbugs.gnu.org \
    --cc=gabriel376@hotmail.com \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).