From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59544: [PATCH] Fixed lib-src/etags.c command execute vulnerability Date: Sun, 27 Nov 2022 20:07:54 +0200 Message-ID: <83edtop8xx.fsf@gnu.org> References: <837czkw7sl.fsf@gnu.org> <8335a8w643.fsf@gnu.org> <83fse7ut10.fsf@gnu.org> <83y1rxsvf6.fsf@gnu.org> <83r0xpssto.fsf@gnu.org> <83h6ylsrcb.fsf@gnu.org> <835yf1skse.fsf@gnu.org> <83o7sspjp1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22450"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59544-done@debbugs.gnu.org, stefankangas@gmail.com To: lux Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 27 19:08:37 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozM4z-0005br-DK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Nov 2022 19:08:37 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozM4S-00049P-Oe; Sun, 27 Nov 2022 13:08:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozM4R-000499-AN for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 13:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozM4R-0007Mh-0Z for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 13:08:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozM4Q-0007NZ-FV for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2022 13:08:02 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2022 18:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security patch Mail-Followup-To: 59544@debbugs.gnu.org, eliz@gnu.org, lx@shellcodes.org Original-Received: via spool by 59544-done@debbugs.gnu.org id=D59544.166957245628347 (code D ref 59544); Sun, 27 Nov 2022 18:08:02 +0000 Original-Received: (at 59544-done) by debbugs.gnu.org; 27 Nov 2022 18:07:36 +0000 Original-Received: from localhost ([127.0.0.1]:43421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozM40-0007N9-Ej for submit@debbugs.gnu.org; Sun, 27 Nov 2022 13:07:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozM3x-0007Mt-U7 for 59544-done@debbugs.gnu.org; Sun, 27 Nov 2022 13:07:34 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozM3r-0007Ej-2r; Sun, 27 Nov 2022 13:07:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lFkWNfF4MI9K8JMASHe9vzYMbGcLUPJjmSQjkAQYdr4=; b=FGTZAncw2A7M ubjU2+66WKvgnl7tBpfLqwd83KLhlGGfxk6zSmYVnXab+Gq24JXgvxYh5sHbEzKmCOZZf1QxXmxK8 wPm80tm3ONu3PySRV3EXYqUGeHcNapYOsiqOd6FWe+Kz9Vy8ViyYBTIxhLMMYW9PLLTxVnSe/7XRm f/bF+ltkDcX/3QHf+WPfvVIpl6OFkY5BSdb5HDbV8YR/7JiWWOPmiuX+IX7knzs74LKXs4qI2UdZN Q7B2OTPBmHgJAs6jh0bVGXnCUM7q1dCIO5l0+uGUkclKslx3p7hQbDYqWrzi4Hnc2i5xHRGTn9Sip gruQfqMxG/VTH4JZ9INkrg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozM3p-0004Mm-Qt; Sun, 27 Nov 2022 13:07:26 -0500 In-Reply-To: (message from lux on Sun, 27 Nov 2022 23:44:07 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249240 Archived-At: > Date: Sun, 27 Nov 2022 23:44:07 +0800 > From: lux > > On Sun, 27 Nov 2022 16:15:38 +0200 > Eli Zaretskii wrote: > > > But something is wrong with the 2 new tests: they fail. I replaced > > the "good" files with the ones I get on my system, but the test fails > > on another system. Could you please look into the test failures and > > find a fix? > > Hi, I think because the order of the tag data of the files generated by > different OS environments is different. > > I sorted the file using the sort command, test ok. > > ctags_update: CTAGS.good_update ${infiles} > head -n 100 CTAGS.good_update > CTAGS > tail -n 100 CTAGS.good_update >> CTAGS > ${RUN} ${CTAGS_PROG} -o CTAGS -u ${ARGS} > diff -u --suppress-common-lines --width=80 <(sort > CTAGS.good_update) <(sort CTAGS) > > cp crlf CTAGS > ${RUN} ${CTAGS_PROG} -o CTAGS -u ${ARGS} > diff -u --suppress-common-lines --width=80 <(sort > CTAGS.good_crlf) <(sort CTAGS) Thanks, I installed a variant of this using more portable commands. And with that, I'm closing this bug.