bug#60644: 30.0.50; eval-defun: in specific case finds wrong function below the current one

bug#60644: 30.0.50; eval-defun: in specific case finds wrong function below the current one

[Jean Louis]

[-- Attachment #1: Type: text/plain, Size: 281 bytes --]


Find in the file two functions, go somewhere in the middle of
`hyperscope-tag-hyperdocuments-by-type' and try invoking C-M-x and you
will see `rcd-db-recurse-on-table' instead of
`hyperscope-tag-hyperdocuments-by-type'. In general I can't instrument
this function interactively.


[-- Attachment #2: test.el --]
[-- Type: text/plain, Size: 1813 bytes --]

(defun hyperscope-tag-hyperdocuments-by-type (&optional list-or-id) 
  "Tag hyperdocuments by their type.

LIST-OR-ID is list of hyperdocuments." 
(interactive)
 (let* ((list-or-id (cond ((and list-or-id 
				(listp list-or-id))
			   list-or-id)
			  (list-or-id (list list-or-id))
			  (t nil)))
	(types (cond (list-or-id 
		      (rcd-sql-list 
		       (format "SELECT DISTINCT hyobjects_hyobjectypes 
                                           FROM hyobjects 
                                          WHERE hyobjects_id IN (%s)" 
			       (mapconcat #'(lambda (id) (format "%s" id)) list-or-id ", ")) 
		       hs-db))
		     (t (rcd-sql-list "SELECT hyobjectypes_id FROM hyobjectypes" hs-db)))))
   (while types 
     (let ((tags (hyperscope-type-tags (pop types))))
       (while tags
	 (let* ((hyperscope-list-limit 10000000)
		(hyobjects (or list-or-id (mapcar #'(lambda (i) (car i)) (hyperscope-list-by-type type)))))
	   (while hyobjects 
	     (let ((hyperdocument (pop hyobjects)))
	       (hyperscope-tag-hyperdocument hyperdocument (pop tags))))))))))

;;(defun hyperscope-by-files)

(defun rcd-db-recurse-on-table (table id-column parent-column id pg &optional include-parent)
  "Return list of children of children for ID.

Optional INCLUDE-PARENT will include parent."
  (let* ((sql (format "WITH RECURSIVE recursetree AS (
                      SELECT s1.%s FROM %s s1 WHERE s1.%s = %s
                      UNION
                      SELECT s2.%s FROM %s s2 
                      JOIN recursetree ON s2.%s = recursetree.%s
                      )
                      SELECT * FROM recursetree"
		      id-column table parent-column id id-column table parent-column id-column))
	 (children (rcd-sql-list sql pg)))
    (cond (include-parent (append (list id) children))
	  (t children))))

[-- Attachment #3: Type: text/plain, Size: 3476 bytes --]




In GNU Emacs 30.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.17.6, Xaw3d scroll bars) of 2023-01-08 built on
 protected.rcdrun.com
Repository revision: 5d1e14bd8b9a11ab860937d3ab97248ddeef30b1
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Parabola GNU/Linux-libre

Configured using:
 'configure --with-x-toolkit=lucid --with-mailutils'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ
JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM
LUCID ZLIB

Important settings:
  value of $LC_ALL: en_US.UTF-8
  value of $LANG: de_DE.UTF-8
  value of $XMODIFIERS: @im=exwm-xim
  locale-coding-system: utf-8-unix

Major mode: Fundamental

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow mailalias emacsbug message yank-media puny dired
dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config
gnus-util text-property-search time-date mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils hyperbole-autoloads
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie generate-lisp-file url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
password-cache json subr-x map byte-opt gv bytecomp byte-compile
url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple
cl-generic indonesian philippine cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button
loaddefs theme-loaddefs faces cus-face macroexp files window
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget keymap hashtable-print-readable backquote threads
dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo x-toolkit xinput2 x multi-tty
make-network-process emacs)

Memory information:
((conses 16 56113 8712)
 (symbols 48 6869 0)
 (strings 32 20665 973)
 (string-bytes 1 617054)
 (vectors 16 14338)
 (vector-slots 8 199567 9406)
 (floats 8 29 36)
 (intervals 56 341 0)
 (buffers 984 10))


-- 
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

bug#60644: 30.0.50; eval-defun: in specific case finds wrong function below the current one

[Eli Zaretskii]

> Date: Sun, 08 Jan 2023 09:19:05 +0300
> From: Jean Louis <bugs@gnu.support>
> 
> Find in the file two functions, go somewhere in the middle of
> `hyperscope-tag-hyperdocuments-by-type' and try invoking C-M-x and you
> will see `rcd-db-recurse-on-table' instead of
> `hyperscope-tag-hyperdocuments-by-type'. In general I can't instrument
> this function interactively.

Its indentation is wrong.  Reindent the line where you have
"(interactive)", and your problems will likely disappear.

bug#60644: 30.0.50; eval-defun: in specific case finds wrong function below the current one

[Jean Louis]

* Eli Zaretskii <eliz@gnu.org> [2023-01-08 13:37]:
> > Date: Sun, 08 Jan 2023 09:19:05 +0300
> > From: Jean Louis <bugs@gnu.support>
> > 
> > Find in the file two functions, go somewhere in the middle of
> > `hyperscope-tag-hyperdocuments-by-type' and try invoking C-M-x and you
> > will see `rcd-db-recurse-on-table' instead of
> > `hyperscope-tag-hyperdocuments-by-type'. In general I can't instrument
> > this function interactively.
> 
> Its indentation is wrong.  Reindent the line where you have
> "(interactive)", and your problems will likely disappear.

I get it, it works.

I was not aware that detection system should rely on indentation, but
rather on sexp.

--
Jean

Take action in Free Software Foundation campaigns:
https://www.fsf.org/campaigns

In support of Richard M. Stallman
https://stallmansupport.org/

bug#60644: 30.0.50; eval-defun: in specific case finds wrong function below the current one

[Eli Zaretskii]

> Date: Sun, 8 Jan 2023 14:21:12 +0300
> From: Jean Louis <bugs@gnu.support>
> Cc: 60644@debbugs.gnu.org
> 
> * Eli Zaretskii <eliz@gnu.org> [2023-01-08 13:37]:
> > > Date: Sun, 08 Jan 2023 09:19:05 +0300
> > > From: Jean Louis <bugs@gnu.support>
> > > 
> > > Find in the file two functions, go somewhere in the middle of
> > > `hyperscope-tag-hyperdocuments-by-type' and try invoking C-M-x and you
> > > will see `rcd-db-recurse-on-table' instead of
> > > `hyperscope-tag-hyperdocuments-by-type'. In general I can't instrument
> > > this function interactively.
> > 
> > Its indentation is wrong.  Reindent the line where you have
> > "(interactive)", and your problems will likely disappear.
> 
> I get it, it works.
> 
> I was not aware that detection system should rely on indentation, but
> rather on sexp.

AFAIU, the top-level form (which is what C-M-x is about) is detected
in a way that depends on indentation.

Stefan, any further comments, or should we close this?

bug#60644: 30.0.50; eval-defun: in specific case finds wrong function below the current one

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> AFAIU, the top-level form (which is what C-M-x is about) is detected
> in a way that depends on indentation.
>
> Stefan, any further comments, or should we close this?

Nothing more to add, other than the fact that I'm also bitten by this
every once in a while.  I'm not sure what could be done about it, tho,
since I'm pretty sure I'd get bitten occasionally no matter what
semantics we pick.

Maybe C-M-x should display visually what it evaluated?

And maybe there sound be some way to force a particular choice (maybe
using the region)?


        Stefan

bug#60644: 30.0.50; eval-defun: in specific case finds wrong function below the current one

[Eli Zaretskii]

severity 60644 wishlist
thanks

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Jean Louis <bugs@gnu.support>,  60644@debbugs.gnu.org
> Date: Sun, 08 Jan 2023 10:23:41 -0500
> 
> > AFAIU, the top-level form (which is what C-M-x is about) is detected
> > in a way that depends on indentation.
> >
> > Stefan, any further comments, or should we close this?
> 
> Nothing more to add, other than the fact that I'm also bitten by this
> every once in a while.  I'm not sure what could be done about it, tho,
> since I'm pretty sure I'd get bitten occasionally no matter what
> semantics we pick.
> 
> Maybe C-M-x should display visually what it evaluated?
> 
> And maybe there sound be some way to force a particular choice (maybe
> using the region)?

Good ideas.  So I think I'll leave the bug open, in case someone would
like to implement these ideas, just make it a feature request.

Thanks.